Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8678ba3 authored by Vishnu Nair's avatar Vishnu Nair
Browse files

Update tests for canReceiveInput policy changes 

Bug: 139494112
Test: atest libgui_test

Change-Id: Ia8d71b95d387d0a912100fd91a4201e36cab5c31
parent adca95f8

libs/gui/tests/EndToEndNativeInputTest.cpp

+10 −12
Original line number Diff line number Diff line
@@ -405,12 +405,11 @@ TEST_F(InputSurfacesTest, input_ignores_transparent_region) { 
    surface->expectTap(1, 1);

}



/**

 * TODO(b/139494112) fix tests once we define expected behavior

 *

// Ensure we send the input to the right surface when the surface visibility changes due to the

// first buffer being submitted. ref: b/120839715

TEST_F(InputSurfacesTest, input_respects_buffer_layer_buffer) {

// TODO(b/139494112) update tests once we define expected behavior

// Ensure we still send input to the surface regardless of surface visibility changes due to the

// first buffer being submitted or alpha changes.

// Original bug ref: b/120839715

TEST_F(InputSurfacesTest, input_ignores_buffer_layer_buffer) {

    std::unique_ptr<InputSurface> bgSurface = makeSurface(100, 100);

    std::unique_ptr<InputSurface> bufferSurface =

            InputSurface::makeBufferInputSurface(mComposerClient, 100, 100);
@@ -419,14 +418,14 @@ TEST_F(InputSurfacesTest, input_respects_buffer_layer_buffer) { 
    bufferSurface->showAt(10, 10);



    injectTap(11, 11);

    bgSurface->expectTap(1, 1);

    bufferSurface->expectTap(1, 1);



    postBuffer(bufferSurface->mSurfaceControl);

    injectTap(11, 11);

    bufferSurface->expectTap(1, 1);

}



TEST_F(InputSurfacesTest, input_respects_buffer_layer_alpha) {

TEST_F(InputSurfacesTest, input_ignores_buffer_layer_alpha) {

    std::unique_ptr<InputSurface> bgSurface = makeSurface(100, 100);

    std::unique_ptr<InputSurface> bufferSurface =

            InputSurface::makeBufferInputSurface(mComposerClient, 100, 100);
@@ -441,10 +440,10 @@ TEST_F(InputSurfacesTest, input_respects_buffer_layer_alpha) { 
    bufferSurface->doTransaction([](auto &t, auto &sc) { t.setAlpha(sc, 0.0); });



    injectTap(11, 11);

    bgSurface->expectTap(1, 1);

    bufferSurface->expectTap(1, 1);

}



TEST_F(InputSurfacesTest, input_respects_color_layer_alpha) {

TEST_F(InputSurfacesTest, input_ignores_color_layer_alpha) {

    std::unique_ptr<InputSurface> bgSurface = makeSurface(100, 100);

    std::unique_ptr<InputSurface> fgSurface = makeSurface(100, 100);
@@ -457,9 +456,8 @@ TEST_F(InputSurfacesTest, input_respects_color_layer_alpha) { 
    fgSurface->doTransaction([](auto &t, auto &sc) { t.setAlpha(sc, 0.0); });



    injectTap(11, 11);

    bgSurface->expectTap(1, 1);

    fgSurface->expectTap(1, 1);

}

*/



TEST_F(InputSurfacesTest, input_respects_container_layer_visiblity) {

    std::unique_ptr<InputSurface> bgSurface = makeSurface(100, 100);