Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7ba41ab authored by Dan Stoza's avatar Dan Stoza
Browse files

SF: Add systrace lines for layer transactions 

Adds new lines to systrace corresponding to when Layers have
transactions (including showing how many transactions are pending when
deferred transactions are used). The new lines are prefixed with "TX - "
to distinguish them from the usual queue occupancy lines.

Test: Manual inspection of systraces
Change-Id: Iebc165a187cf87b6bc1ed4de6595463f5ba9d4fe
parent 78d69df3

services/surfaceflinger/Layer.cpp

+3 −0
Original line number Diff line number Diff line
@@ -126,6 +126,7 @@ Layer::Layer(SurfaceFlinger* flinger, const sp<Client>& client, 
        mPremultipliedAlpha = false;



    mName = name;

    mTransactionName = String8("TX - ") + mName;



    mCurrentState.active.w = w;

    mCurrentState.active.h = h;
@@ -1482,6 +1483,7 @@ void Layer::pushPendingState() { 
        mFlinger->setTransactionFlags(eTraversalNeeded);

    }

    mPendingStates.push_back(mCurrentState);

    ATRACE_INT(mTransactionName.string(), mPendingStates.size());

}



void Layer::popPendingState(State* stateToCommit) {
@@ -1491,6 +1493,7 @@ void Layer::popPendingState(State* stateToCommit) { 
            (stateToCommit->flags & stateToCommit->mask);



    mPendingStates.removeAt(0);

    ATRACE_INT(mTransactionName.string(), mPendingStates.size());

}



bool Layer::applyPendingStates(State* stateToCommit) {

services/surfaceflinger/Layer.h

+1 −0
Original line number Diff line number Diff line
@@ -657,6 +657,7 @@ private: 
    uint32_t mTextureName;      // from GLES

    bool mPremultipliedAlpha;

    String8 mName;

    String8 mTransactionName; // A cached version of "TX - " + mName for systraces

    PixelFormat mFormat;



    // these are protected by an external lock