Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6b3dc2a authored by Fan Xu's avatar Fan Xu
Browse files

Remove BufferHubBuffer:Poll function 

In the new eventFd design, BufferHubBuffer will only provide with the
eventfd itself, and user can decide what to do with it. Therefore, the
Poll function is not needed any more.

Test: BufferHub_test, GraphicBuffer_test
Bug: 118891412
Change-Id: I5f5ff71bcedc20de81f246764e878d81b0768eb1
parent 7ab76b1c

libs/ui/BufferHubBuffer.cpp

+0 −5
Original line number Diff line number Diff line
@@ -319,11 +319,6 @@ bool BufferHubBuffer::IsValid() const { 
            mMetadata.IsValid() && mBufferClient != nullptr;

}



// TODO(b/68770788): implement Poll() once we have event fd

int BufferHubBuffer::Poll(int /* timeoutMs */) {

    return -ENOSYS;

}



native_handle_t* BufferHubBuffer::Duplicate() {

    if (mBufferClient == nullptr) {

        ALOGE("%s: missing BufferClient!", __FUNCTION__);

libs/ui/include/ui/BufferHubBuffer.h

+0 −3
Original line number Diff line number Diff line
@@ -94,9 +94,6 @@ public: 
    // current cycle of the usage of the buffer.

    int Release();



    // Polls the fd for |timeoutMs| milliseconds (-1 for infinity).

    int Poll(int timeoutMs);



    // Creates a token that stands for this BufferHubBuffer client and could be used for Import to

    // create another BufferHubBuffer. The new BufferHubBuffer will share the same underlying

    // gralloc buffer and ashmem region for metadata. Note that the caller owns the token and