Commit f5a5bb84 authored Dec 16, 2021 by Steven Moreland

libbinder: log when wrong number of threads start

Add a log when a service requests to have 0 threads but a threadpool
(with a thread) is still requested to be started). This currently
doesn't get hit on cuttlefish, but by triggering it manually I
can see the log.

Bug: 210145621
Test: trigger API misuse case and check for log
Change-Id: I9113828e10812895802a83017ed8f55e851fa220

parent 6e7f072d

libs/binder/ProcessState.cpp

+5 −0

Original line number	Diff line number	Diff line
		@@ -176,6 +176,11 @@ void ProcessState::startThreadPool()
		{
		AutoMutex _l(mLock);
		if (!mThreadPoolStarted) {
		if (mMaxThreads == 0) {
		ALOGW("Extra binder thread started, but 0 threads requested. Do not use "
		"*startThreadPool when zero threads are requested.");
		}

		mThreadPoolStarted = true;
		spawnPooledThread(true);
		}