Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f427f769 authored by Adithya Srinivasan's avatar Adithya Srinivasan
Browse files

Fix TimeStats layerName for transactions 

Due to a human error, layer name for transactions was being assigned
the default game mode.

Bug: 191166065
Test: libsurfaceflinger_unittest
Change-Id: I1c0e1b86c9157cb5b99c737554218477860513a6
parent f75789e7

services/surfaceflinger/TimeStats/TimeStats.cpp

+2 −2
Original line number Original line Diff line number Diff line
@@ -846,8 +846,8 @@ void TimeStats::incrementJankyFrames(const JankyFramesInfo& info) { 
        timelineStats.stats[layerKey].displayRefreshRateBucket = refreshRateBucket;

        timelineStats.stats[layerKey].displayRefreshRateBucket = refreshRateBucket;

        timelineStats.stats[layerKey].renderRateBucket = renderRateBucket;

        timelineStats.stats[layerKey].renderRateBucket = renderRateBucket;

        timelineStats.stats[layerKey].uid = info.uid;

        timelineStats.stats[layerKey].uid = info.uid;

        timelineStats.stats[layerKey].layerName = kDefaultGameMode;

        timelineStats.stats[layerKey].layerName = kDefaultLayerName;

        timelineStats.stats[layerKey].gameMode = info.gameMode;

        timelineStats.stats[layerKey].gameMode = kDefaultGameMode;

    }

    }





    TimeStatsHelper::TimeStatsLayer& timeStatsLayer = timelineStats.stats[layerKey];

    TimeStatsHelper::TimeStatsLayer& timeStatsLayer = timelineStats.stats[layerKey];

services/surfaceflinger/TimeStats/TimeStats.h

+1 −9
Original line number Original line Diff line number Diff line
@@ -16,18 +16,10 @@ 




#pragma once

#pragma once





// TODO(b/129481165): remove the #pragma below and fix conversion issues

#include <cstdint>

#include <cstdint>

#pragma clang diagnostic push

#pragma clang diagnostic ignored "-Wconversion"

#pragma clang diagnostic ignored "-Wextra"



#include <android/hardware/graphics/composer/2.4/IComposerClient.h>



// TODO(b/129481165): remove the #pragma below and fix conversion issues

#pragma clang diagnostic pop // ignored "-Wconversion -Wextra"





#include <../Fps.h>

#include <../Fps.h>

#include <android/hardware/graphics/composer/2.4/IComposerClient.h>

#include <gui/JankInfo.h>

#include <gui/JankInfo.h>

#include <timestatsproto/TimeStatsHelper.h>

#include <timestatsproto/TimeStatsHelper.h>

#include <timestatsproto/TimeStatsProtoHeader.h>

#include <timestatsproto/TimeStatsProtoHeader.h>