Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eecb8666 authored by John Reck's avatar John Reck
Browse files

Revert "atrace: Make atrace notify VR services of new trace sessions" 

This reverts commit 213feb32.

Reason for revert: tracing & perf teams don't want to support PDX at this point in time.

Change-Id: I28b8a7c55c9d31c8469236fb60a6e034b1ef8af7
parent 213feb32

cmds/atrace/Android.bp

+0 −3
Original line number Diff line number Diff line
@@ -16,9 +16,6 @@ cc_binary { 
        "libz",

        "libbase",

    ],

    static_libs: [

        "libpdx_default_transport",

    ],



    init_rc: ["atrace.rc"],

}

cmds/atrace/atrace.cpp

+0 −45
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@ 


#include <errno.h>

#include <fcntl.h>

#include <ftw.h>

#include <getopt.h>

#include <inttypes.h>

#include <signal.h>
@@ -42,7 +41,6 @@ 
#include <hidl/ServiceManagement.h>

#include <cutils/properties.h>



#include <pdx/default_transport/service_utility.h>

#include <utils/String8.h>

#include <utils/Timers.h>

#include <utils/Tokenizer.h>
@@ -50,7 +48,6 @@ 
#include <android-base/file.h>



using namespace android;

using pdx::default_transport::ServiceUtility;



using std::string;

#define NELEM(x) ((int) (sizeof(x) / sizeof((x)[0])))
@@ -572,46 +569,6 @@ static void pokeHalServices() 
    }

}



// Sends the sysprop_change message to the service at fpath, so it re-reads its

// system properties. Returns 0 on success or a negated errno code on failure.

static int pokeOnePDXService(const char *fpath, const struct stat * /*sb*/,

                             int typeflag, struct FTW * /*ftwbuf*/)

{

    const bool kIgnoreErrors = true;



    if (typeflag == FTW_F) {

        int error;

        auto utility = ServiceUtility::Create(fpath, &error);

        if (!utility) {

            if (error != -ECONNREFUSED) {

                ALOGE("pokeOnePDXService: Failed to open %s, %s.", fpath,

                      strerror(-error));

            }

            return kIgnoreErrors ? 0 : error;

        }



        auto status = utility->ReloadSystemProperties();

        if (!status) {

            ALOGE("pokeOnePDXService: Failed to send sysprop change to %s, "

                  "error %d, %s.", fpath, status.error(),

                  status.GetErrorMessage().c_str());

            return kIgnoreErrors ? 0 : -status.error();

        }

    }



    return 0;

}



// Pokes all the PDX processes in the system to get them to re-read

// their system properties. Returns true on success, false on failure.

static bool pokePDXServices()

{

    const int kMaxDepth = 16;

    const int result = nftw(ServiceUtility::GetRootEndpointPath().c_str(),

                            pokeOnePDXService, kMaxDepth, FTW_PHYS);

    return result == 0 ? true : false;

}



// Set the trace tags that userland tracing uses, and poke the running

// processes to pick up the new value.

static bool setTagsProperty(uint64_t tags)
@@ -855,7 +812,6 @@ static bool setUpTrace() 
    ok &= setAppCmdlineProperty(&packageList[0]);

    ok &= pokeBinderServices();

    pokeHalServices();

    ok &= pokePDXServices();



    // Disable all the sysfs enables.  This is done as a separate loop from

    // the enables to allow the same enable to exist in multiple categories.
@@ -893,7 +849,6 @@ static void cleanUpTrace() 
    setTagsProperty(0);

    clearAppProperties();

    pokeBinderServices();

    pokePDXServices();



    // Set the options back to their defaults.

    setTraceOverwriteEnable(true);