Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb8505cc authored by Harpreet \"Eli\" Sangha's avatar Harpreet \"Eli\" Sangha
Browse files

idlcli: vibrator: Add Missing APIs



Test: Manual
Signed-off-by: default avatarHarpreet \"Eli\" Sangha <eliptus@google.com>
Change-Id: I88fafe55369897dd9785e0fcfd04b402f169f3d8
parent bbe7855e
Loading
Loading
Loading
Loading
+6 −0
Original line number Diff line number Diff line
@@ -37,10 +37,16 @@ cc_library {
    defaults: ["idlcli-defaults"],
    srcs: [
        "CommandVibrator.cpp",
        "vibrator/CommandAlwaysOnDisable.cpp",
        "vibrator/CommandAlwaysOnEnable.cpp",
        "vibrator/CommandCompose.cpp",
        "vibrator/CommandGetCapabilities.cpp",
        "vibrator/CommandGetCompositionDelayMax.cpp",
        "vibrator/CommandGetCompositionSizeMax.cpp",
        "vibrator/CommandGetPrimitiveDuration.cpp",
        "vibrator/CommandGetSupportedAlwaysOnEffects.cpp",
        "vibrator/CommandGetSupportedEffects.cpp",
        "vibrator/CommandGetSupportedPrimitives.cpp",
        "vibrator/CommandOff.cpp",
        "vibrator/CommandOn.cpp",
        "vibrator/CommandPerform.cpp",
+2 −1
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@
#ifndef FRAMEWORK_NATIVE_CMDS_IDLCLI_UTILS_H_
#define FRAMEWORK_NATIVE_CMDS_IDLCLI_UTILS_H_

#include <android/binder_enums.h>
#include <hidl/HidlSupport.h>

#include <iomanip>
@@ -66,7 +67,7 @@ inline std::istream &operator>>(std::istream &stream, uint8_t &out) {

} // namespace overrides

template <typename T, typename R = hardware::hidl_enum_range<T>>
template <typename T, typename R = ndk::enum_range<T>>
inline std::istream &operator>>(std::istream &stream, T &out) {
    using overrides::operator>>;
    auto validRange = R();
+79 −0
Original line number Diff line number Diff line
/*
 * Copyright (C) 2020 The Android Open Source Project *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

#include "utils.h"
#include "vibrator.h"

namespace android {
namespace idlcli {

class CommandVibrator;

namespace vibrator {

class CommandAlwaysOnDisable : public Command {
    std::string getDescription() const override { return "Disarm always-on haptic source."; }

    std::string getUsageSummary() const override { return "<id>"; }

    UsageDetails getUsageDetails() const override {
        UsageDetails details{
                {"<id>", {"Source ID (device-specific)."}},
        };
        return details;
    }

    Status doArgs(Args &args) override {
        if (auto id = args.pop<decltype(mId)>()) {
            mId = *id;
            std::cout << "Source ID: " << mId << std::endl;
        } else {
            std::cerr << "Missing or Invalid Source ID!" << std::endl;
            return USAGE;
        }
        if (!args.empty()) {
            std::cerr << "Unexpected Arguments!" << std::endl;
            return USAGE;
        }
        return OK;
    }

    Status doMain(Args && /*args*/) override {
        std::string statusStr;
        Status ret;

        if (auto hal = getHal<aidl::IVibrator>()) {
            auto status = hal->call(&aidl::IVibrator::alwaysOnDisable, mId);

            statusStr = status.getDescription();
            ret = status.isOk() ? OK : ERROR;
        } else {
            return UNAVAILABLE;
        }

        std::cout << "Status: " << statusStr << std::endl;

        return ret;
    }

    int32_t mId;
};

static const auto Command =
        CommandRegistry<CommandVibrator>::Register<CommandAlwaysOnDisable>("alwaysOnDisable");

} // namespace vibrator
} // namespace idlcli
} // namespace android
+102 −0
Original line number Diff line number Diff line
/*
 * Copyright (C) 2020 The Android Open Source Project *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

#include "utils.h"
#include "vibrator.h"

namespace android {
namespace idlcli {

class CommandVibrator;

namespace vibrator {

using aidl::Effect;
using aidl::EffectStrength;

class CommandAlwaysOnEnable : public Command {
    std::string getDescription() const override {
        return "Arm always-on haptic source with an effect.";
    }

    std::string getUsageSummary() const override { return "<id> <effect> <strength>"; }

    UsageDetails getUsageDetails() const override {
        UsageDetails details{
                {"<id>", {"Source ID (device-specific)."}},
                {"<effect>", {"Effect ID."}},
                {"<strength>", {"0-2."}},
        };
        return details;
    }

    Status doArgs(Args &args) override {
        if (auto id = args.pop<decltype(mId)>()) {
            mId = *id;
            std::cout << "Source ID: " << mId << std::endl;
        } else {
            std::cerr << "Missing or Invalid Source ID!" << std::endl;
            return USAGE;
        }
        if (auto effect = args.pop<decltype(mEffect)>()) {
            mEffect = *effect;
            std::cout << "Effect: " << toString(mEffect) << std::endl;
        } else {
            std::cerr << "Missing or Invalid Effect!" << std::endl;
            return USAGE;
        }
        if (auto strength = args.pop<decltype(mStrength)>()) {
            mStrength = *strength;
            std::cout << "Strength: " << toString(mStrength) << std::endl;
        } else {
            std::cerr << "Missing or Invalid Strength!" << std::endl;
            return USAGE;
        }
        if (!args.empty()) {
            std::cerr << "Unexpected Arguments!" << std::endl;
            return USAGE;
        }
        return OK;
    }

    Status doMain(Args && /*args*/) override {
        std::string statusStr;
        Status ret;

        if (auto hal = getHal<aidl::IVibrator>()) {
            auto status = hal->call(&aidl::IVibrator::alwaysOnEnable, mId, mEffect, mStrength);

            statusStr = status.getDescription();
            ret = status.isOk() ? OK : ERROR;
        } else {
            return UNAVAILABLE;
        }

        std::cout << "Status: " << statusStr << std::endl;

        return ret;
    }

    int32_t mId;
    Effect mEffect;
    EffectStrength mStrength;
};

static const auto Command =
        CommandRegistry<CommandVibrator>::Register<CommandAlwaysOnEnable>("alwaysOnEnable");

} // namespace vibrator
} // namespace idlcli
} // namespace android
+2 −3
Original line number Diff line number Diff line
@@ -64,9 +64,8 @@ class CommandCompose : public Command {
                std::cerr << "Missing or Invalid Delay!" << std::endl;
                return USAGE;
            }
            // TODO: Use range validation when supported by AIDL
            if (auto primitive = args.pop<std::underlying_type_t<decltype(effect.primitive)>>()) {
                effect.primitive = static_cast<decltype(effect.primitive)>(*primitive);
            if (auto primitive = args.pop<decltype(effect.primitive)>()) {
                effect.primitive = *primitive;
                std::cout << "Primitive: " << toString(effect.primitive) << std::endl;
            } else {
                std::cerr << "Missing or Invalid Primitive!" << std::endl;
Loading