Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9d2c541 authored by Felipe Leme's avatar Felipe Leme
Browse files

Always remove the temporary zip file. 

During N development, this file was only removed on user builds.

Change-Id: I16eba3905301662b802986d27cb8fcf6e0e34e01
Fixes: 32906722
Test: manual verification
parent e52d9e2a

cmds/dumpstate/dumpstate.cpp

+3 −7
Original line number Diff line number Diff line
@@ -1253,13 +1253,9 @@ bool Dumpstate::FinishZipFile() { 
    // TODO: remove once FinishZipFile() is automatically handled by Dumpstate's destructor.

    ds.zip_file.reset(nullptr);



    if (IsUserBuild()) {

    MYLOGD("Removing temporary file %s\n", tmp_path_.c_str())

    if (remove(tmp_path_.c_str()) != 0) {

            ALOGW("remove(%s): %s\n", tmp_path_.c_str(), strerror(errno));

        }

    } else {

        MYLOGD("Keeping temporary file %s on non-user build\n", tmp_path_.c_str())

        MYLOGE("Failed to remove temporary file (%s): %s\n", tmp_path_.c_str(), strerror(errno));

    }



    return true;