Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit def77198 authored by Jeongik Cha's avatar Jeongik Cha
Browse files

ParcelableHolder uses its address for comparison 

For both C++ and NDK, ParcelableHolder just uses its address for
comparison.

Bug: 175072152
Test: atest aidl_integration_test
Change-Id: Id292009ac9d8763eca094eb9597defd98a5d6969
parent f30487a1

libs/binder/include/binder/ParcelableHolder.h

+6 −12
Original line number Diff line number Diff line
@@ -104,28 +104,22 @@ public: 
    Stability getStability() const override { return mStability; }



    inline bool operator!=(const ParcelableHolder& rhs) const {

        return std::tie(mParcelable, mParcelPtr, mStability) !=

                std::tie(rhs.mParcelable, rhs.mParcelPtr, rhs.mStability);

        return this != &rhs;

    }

    inline bool operator<(const ParcelableHolder& rhs) const {

        return std::tie(mParcelable, mParcelPtr, mStability) <

                std::tie(rhs.mParcelable, rhs.mParcelPtr, rhs.mStability);

        return this < &rhs;

    }

    inline bool operator<=(const ParcelableHolder& rhs) const {

        return std::tie(mParcelable, mParcelPtr, mStability) <=

                std::tie(rhs.mParcelable, rhs.mParcelPtr, rhs.mStability);

        return this <= &rhs;

    }

    inline bool operator==(const ParcelableHolder& rhs) const {

        return std::tie(mParcelable, mParcelPtr, mStability) ==

                std::tie(rhs.mParcelable, rhs.mParcelPtr, rhs.mStability);

        return this == &rhs;

    }

    inline bool operator>(const ParcelableHolder& rhs) const {

        return std::tie(mParcelable, mParcelPtr, mStability) >

                std::tie(rhs.mParcelable, rhs.mParcelPtr, rhs.mStability);

        return this > &rhs;

    }

    inline bool operator>=(const ParcelableHolder& rhs) const {

        return std::tie(mParcelable, mParcelPtr, mStability) >=

                std::tie(rhs.mParcelable, rhs.mParcelPtr, rhs.mStability);

        return this >= &rhs;

    }



private:

libs/binder/ndk/include_cpp/android/binder_parcelable_utils.h

+6 −18
Original line number Diff line number Diff line
@@ -114,24 +114,12 @@ class AParcelableHolder { 


    void reset() { AParcel_reset(mParcel.get()); }



    inline bool operator!=(const AParcelableHolder& rhs) const {

        return std::tie(mParcel, mStability) != std::tie(rhs.mParcel, rhs.mStability);

    }

    inline bool operator<(const AParcelableHolder& rhs) const {

        return std::tie(mParcel, mStability) < std::tie(rhs.mParcel, rhs.mStability);

    }

    inline bool operator<=(const AParcelableHolder& rhs) const {

        return std::tie(mParcel, mStability) <= std::tie(rhs.mParcel, rhs.mStability);

    }

    inline bool operator==(const AParcelableHolder& rhs) const {

        return std::tie(mParcel, mStability) == std::tie(rhs.mParcel, rhs.mStability);

    }

    inline bool operator>(const AParcelableHolder& rhs) const {

        return std::tie(mParcel, mStability) > std::tie(rhs.mParcel, rhs.mStability);

    }

    inline bool operator>=(const AParcelableHolder& rhs) const {

        return std::tie(mParcel, mStability) >= std::tie(rhs.mParcel, rhs.mStability);

    }

    inline bool operator!=(const AParcelableHolder& rhs) const { return this != &rhs; }

    inline bool operator<(const AParcelableHolder& rhs) const { return this < &rhs; }

    inline bool operator<=(const AParcelableHolder& rhs) const { return this <= &rhs; }

    inline bool operator==(const AParcelableHolder& rhs) const { return this == &rhs; }

    inline bool operator>(const AParcelableHolder& rhs) const { return this > &rhs; }

    inline bool operator>=(const AParcelableHolder& rhs) const { return this >= &rhs; }



   private:

    mutable ndk::ScopedAParcel mParcel;