Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc23aff2 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "Fix/suppress libs/vr google-explicit-constructor warnings"

parents 6a525c47 79e7f1b5
Loading
Loading
Loading
Loading
+3 −3
Original line number Diff line number Diff line
@@ -130,8 +130,8 @@ class BufferHubQueue : public pdx::Client {
  bool hung_up() const { return hung_up_; }

 protected:
  BufferHubQueue(pdx::LocalChannelHandle channel);
  BufferHubQueue(const std::string& endpoint_path);
  explicit BufferHubQueue(pdx::LocalChannelHandle channel);
  explicit BufferHubQueue(const std::string& endpoint_path);

  // Imports the queue parameters by querying BufferHub for the parameters for
  // this channel.
@@ -417,7 +417,7 @@ class ConsumerQueue : public BufferHubQueue {
 private:
  friend BufferHubQueue;

  ConsumerQueue(pdx::LocalChannelHandle handle);
  explicit ConsumerQueue(pdx::LocalChannelHandle handle);

  // Add a consumer buffer to populate the queue. Once added, a consumer buffer
  // is NOT available to use until the producer side |Post| it. |WaitForBuffers|
+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ class BufferHubQueueParcelable : public Parcelable {
  }

  // Constructs an parcelable contains the channel parcelable.
  BufferHubQueueParcelable(
  explicit BufferHubQueueParcelable(
      std::unique_ptr<pdx::ChannelParcelable> channel_parcelable)
      : channel_parcelable_(std::move(channel_parcelable)) {}

+2 −0
Original line number Diff line number Diff line
@@ -60,11 +60,13 @@ class Flags {
  using Base = Flags<Integer>;
  using Type = Integer;

  // NOLINTNEXTLINE(google-explicit-constructor)
  Flags(const Integer& value) : value_{value} {}
  Flags(const Flags&) = default;
  Flags& operator=(const Flags&) = default;

  Integer value() const { return value_; }
  // NOLINTNEXTLINE(google-explicit-constructor)
  operator Integer() const { return value_; }

  bool IsSet(Integer bits) const { return (value_ & bits) == bits; }
+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ class ChannelManagerInterface {
class ChannelHandleBase {
 public:
  ChannelHandleBase() = default;
  ChannelHandleBase(const int32_t& value) : value_{value} {}
  explicit ChannelHandleBase(const int32_t& value) : value_{value} {}

  ChannelHandleBase(const ChannelHandleBase&) = delete;
  ChannelHandleBase& operator=(const ChannelHandleBase&) = delete;
+1 −1
Original line number Diff line number Diff line
@@ -206,7 +206,7 @@ class ClientBase : public ParentClient {
class Transaction final : public OutputResourceMapper,
                          public InputResourceMapper {
 public:
  Transaction(Client& client);
  explicit Transaction(Client& client);
  ~Transaction();

  template <typename T>
Loading