Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d968eec2 authored by Rachel Lee's avatar Rachel Lee
Browse files

Remove unused private Choreographer apis. 

getInterval is still in use so it will be removed later.

Bug: 198192636
Test: atest ChoreographerNativeTest; atest AnimatedImageDrawableTest
Change-Id: Ic319ebd3b073af3669c75c6c83552372e807c47c
parent bf8caa61

libs/nativedisplay/AChoreographer.cpp

+0 −18
Original line number Diff line number Diff line
@@ -151,8 +151,6 @@ public: 


    static Choreographer* getForThread();

    virtual ~Choreographer() override EXCLUDES(gChoreographers.lock);

    int64_t getVsyncId() const;

    int64_t getFrameDeadline() const;

    int64_t getFrameInterval() const;

    bool inCallback() const;
@@ -449,14 +447,6 @@ void Choreographer::handleMessage(const Message& message) { 
    }

}



int64_t Choreographer::getVsyncId() const {

    return mLastVsyncEventData.id;

}



int64_t Choreographer::getFrameDeadline() const {

    return mLastVsyncEventData.deadlineTimestamp;

}



int64_t Choreographer::getFrameInterval() const {

    return mLastVsyncEventData.frameInterval;

}
@@ -587,14 +577,6 @@ int64_t AChoreographerFrameCallbackData_routeGetFrameTimelineDeadline( 
    return AChoreographerFrameCallbackData_getFrameTimelineDeadline(data, index);

}



int64_t AChoreographer_getVsyncId(const AChoreographer* choreographer) {

    return AChoreographer_to_Choreographer(choreographer)->getVsyncId();

}



int64_t AChoreographer_getFrameDeadline(const AChoreographer* choreographer) {

    return AChoreographer_to_Choreographer(choreographer)->getFrameDeadline();

}



int64_t AChoreographer_getFrameInterval(const AChoreographer* choreographer) {

    return AChoreographer_to_Choreographer(choreographer)->getFrameInterval();

}

libs/nativedisplay/include-private/private/android/choreographer.h

+0 −13
Original line number Diff line number Diff line
@@ -29,19 +29,6 @@ void AChoreographer_initJVM(JNIEnv* env); 
// for consumption by callbacks.

void AChoreographer_signalRefreshRateCallbacks(int64_t vsyncPeriod);



// Returns the vsync id of the last frame callback. Client are expected to call

// this function from their frame callback function to get the vsyncId and pass

// it together with a buffer or transaction to the Surface Composer. Calling

// this function from anywhere else will return an undefined value.

int64_t AChoreographer_getVsyncId(const AChoreographer* choreographer);



// Returns the deadline timestamp (in CLOCK_MONOTONIC) of the last frame callback.

// Client are expected to call this function from their frame callback function

// to get the deadline and use it to know whether a frame is likely to miss

// presentation. Calling this function from anywhere else will return an undefined

// value.

int64_t AChoreographer_getFrameDeadline(const AChoreographer* choreographer);



// Returns the current interval in ns between frames.

// Client are expected to call this function from their frame callback function.

// Calling this function from anywhere else will return an undefined value.

libs/nativedisplay/libnativedisplay.map.txt

+0 −2
Original line number Diff line number Diff line
@@ -43,8 +43,6 @@ LIBNATIVEDISPLAY_PLATFORM { 
      android::AChoreographerFrameCallbackData_routeGetFrameTimelineExpectedPresentTime*;

      android::AChoreographerFrameCallbackData_routeGetFrameTimelineDeadline*;

      android::AChoreographer_signalRefreshRateCallbacks*;

      android::AChoreographer_getVsyncId*;

      android::AChoreographer_getFrameDeadline*;

      android::AChoreographer_getFrameInterval*;

      android::ADisplay_acquirePhysicalDisplays*;

      android::ADisplay_release*;