Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cfeebd4b authored by Marin Shalamanov's avatar Marin Shalamanov
Browse files

[SF] Rename variables to match style 

This CL renames the variables so they are more readable and changes
snake case to camel case.

Test: m
Bug: 153991408
Change-Id: I80faa91ab514395dbf53c52282d62444c9aa579a
parent 81ab746c

services/surfaceflinger/CompositionEngine/src/OutputLayer.cpp

+15 −15
Original line number Original line Diff line number Diff line
@@ -149,9 +149,9 @@ FloatRect OutputLayer::calculateOutputSourceCrop() const { 
        // a modification of the axes of rotation. To account for this we

        // a modification of the axes of rotation. To account for this we

        // need to reorient the inverse rotation in terms of the current

        // need to reorient the inverse rotation in terms of the current

        // axes of rotation.

        // axes of rotation.

        bool is_h_flipped = (invTransform & HAL_TRANSFORM_FLIP_H) != 0;

        bool isHFlipped = (invTransform & HAL_TRANSFORM_FLIP_H) != 0;

        bool is_v_flipped = (invTransform & HAL_TRANSFORM_FLIP_V) != 0;

        bool isVFlipped = (invTransform & HAL_TRANSFORM_FLIP_V) != 0;

        if (is_h_flipped == is_v_flipped) {

        if (isHFlipped == isVFlipped) {

            invTransform ^= HAL_TRANSFORM_FLIP_V | HAL_TRANSFORM_FLIP_H;

            invTransform ^= HAL_TRANSFORM_FLIP_V | HAL_TRANSFORM_FLIP_H;

        }

        }

        std::swap(winWidth, winHeight);

        std::swap(winWidth, winHeight);
@@ -160,18 +160,18 @@ FloatRect OutputLayer::calculateOutputSourceCrop() const { 
            activeCrop.transform(invTransform, bufferSize.getWidth(), bufferSize.getHeight());

            activeCrop.transform(invTransform, bufferSize.getWidth(), bufferSize.getHeight());





    // below, crop is intersected with winCrop expressed in crop's coordinate space

    // below, crop is intersected with winCrop expressed in crop's coordinate space

    float xScale = crop.getWidth() / float(winWidth);

    const float xScale = crop.getWidth() / float(winWidth);

    float yScale = crop.getHeight() / float(winHeight);

    const float yScale = crop.getHeight() / float(winHeight);





    float insetL = winCrop.left * xScale;

    const float insetLeft = winCrop.left * xScale;

    float insetT = winCrop.top * yScale;

    const float insetTop = winCrop.top * yScale;

    float insetR = (winWidth - winCrop.right) * xScale;

    const float insetRight = (winWidth - winCrop.right) * xScale;

    float insetB = (winHeight - winCrop.bottom) * yScale;

    const float insetBottom = (winHeight - winCrop.bottom) * yScale;





    crop.left += insetL;

    crop.left += insetLeft;

    crop.top += insetT;

    crop.top += insetTop;

    crop.right -= insetR;

    crop.right -= insetRight;

    crop.bottom -= insetB;

    crop.bottom -= insetBottom;





    return crop;

    return crop;

}

}

services/surfaceflinger/DisplayDevice.cpp

+24 −24
Original line number Original line Diff line number Diff line
@@ -156,19 +156,19 @@ void DisplayDevice::setProjection(ui::Rotation orientation, Rect viewport, Rect 
    mOrientation = orientation;

    mOrientation = orientation;





    const Rect& displayBounds = getCompositionDisplay()->getState().bounds;

    const Rect& displayBounds = getCompositionDisplay()->getState().bounds;

    const int w = displayBounds.width();

    const int displayWidth = displayBounds.width();

    const int h = displayBounds.height();

    const int displayHeight = displayBounds.height();





    ui::Transform R;

    ui::Transform rotation;

    if (const auto flags = ui::Transform::toRotationFlags(orientation);

    if (const auto flags = ui::Transform::toRotationFlags(orientation);

        flags != ui::Transform::ROT_INVALID) {

        flags != ui::Transform::ROT_INVALID) {

        R.set(flags, w, h);

        rotation.set(flags, displayWidth, displayHeight);

    }

    }





    if (!frame.isValid()) {

    if (!frame.isValid()) {

        // the destination frame can be invalid if it has never been set,

        // the destination frame can be invalid if it has never been set,

        // in that case we assume the whole display frame.

        // in that case we assume the whole display frame.

        frame = Rect(w, h);

        frame = Rect(displayWidth, displayHeight);

    }

    }





    if (viewport.isEmpty()) {

    if (viewport.isEmpty()) {
@@ -176,45 +176,45 @@ void DisplayDevice::setProjection(ui::Rotation orientation, Rect viewport, Rect 
        // we assume the whole display size.

        // we assume the whole display size.

        // it's also invalid to have an empty viewport, so we handle that

        // it's also invalid to have an empty viewport, so we handle that

        // case in the same way.

        // case in the same way.

        viewport = Rect(w, h);

        viewport = Rect(displayWidth, displayHeight);

        if (R.getOrientation() & ui::Transform::ROT_90) {

        if (rotation.getOrientation() & ui::Transform::ROT_90) {

            // viewport is always specified in the logical orientation

            // viewport is always specified in the logical orientation

            // of the display (ie: post-rotation).

            // of the display (ie: post-rotation).

            std::swap(viewport.right, viewport.bottom);

            std::swap(viewport.right, viewport.bottom);

        }

        }

    }

    }





    ui::Transform TL, TP, S;

    ui::Transform logicalTranslation, physicalTranslation, scale;

    float src_width  = viewport.width();

    const float sourceWidth = viewport.width();

    float src_height = viewport.height();

    const float sourceHeight = viewport.height();

    float dst_width  = frame.width();

    const float destWidth = frame.width();

    float dst_height = frame.height();

    const float destHeight = frame.height();

    if (src_width != dst_width || src_height != dst_height) {

    if (sourceWidth != destWidth || sourceHeight != destHeight) {

        float sx = dst_width  / src_width;

        const float scaleX = destWidth / sourceWidth;

        float sy = dst_height / src_height;

        const float scaleY = destHeight / sourceHeight;

        S.set(sx, 0, 0, sy);

        scale.set(scaleX, 0, 0, scaleY);

    }

    }





    float src_x = viewport.left;

    const float sourceX = viewport.left;

    float src_y = viewport.top;

    const float sourceY = viewport.top;

    float dst_x = frame.left;

    const float destX = frame.left;

    float dst_y = frame.top;

    const float destY = frame.top;

    TL.set(-src_x, -src_y);

    logicalTranslation.set(-sourceX, -sourceY);

    TP.set(dst_x, dst_y);

    physicalTranslation.set(destX, destY);





    // need to take care of primary display rotation for globalTransform

    // need to take care of primary display rotation for globalTransform

    // for case if the panel is not installed aligned with device orientation

    // for case if the panel is not installed aligned with device orientation

    if (isPrimary()) {

    if (isPrimary()) {

        if (const auto flags = ui::Transform::toRotationFlags(orientation + mPhysicalOrientation);

        if (const auto flags = ui::Transform::toRotationFlags(orientation + mPhysicalOrientation);

            flags != ui::Transform::ROT_INVALID) {

            flags != ui::Transform::ROT_INVALID) {

            R.set(flags, w, h);

            rotation.set(flags, displayWidth, displayHeight);

        }

        }

    }

    }





    // The viewport and frame are both in the logical orientation.

    // The viewport and frame are both in the logical orientation.

    // Apply the logical translation, scale to physical size, apply the

    // Apply the logical translation, scale to physical size, apply the

    // physical translation and finally rotate to the physical orientation.

    // physical translation and finally rotate to the physical orientation.

    ui::Transform globalTransform = R * TP * S * TL;

    ui::Transform globalTransform = rotation * physicalTranslation * scale * logicalTranslation;





    const uint8_t type = globalTransform.getType();

    const uint8_t type = globalTransform.getType();

    const bool needsFiltering =

    const bool needsFiltering =

services/surfaceflinger/Scheduler/Scheduler.cpp

+4 −4
Original line number Original line Diff line number Diff line
@@ -66,15 +66,15 @@ std::unique_ptr<DispSync> createDispSync() { 
    // TODO (140302863) remove this and use the vsync_reactor system.

    // TODO (140302863) remove this and use the vsync_reactor system.

    if (property_get_bool("debug.sf.vsync_reactor", true)) {

    if (property_get_bool("debug.sf.vsync_reactor", true)) {

        // TODO (144707443) tune Predictor tunables.

        // TODO (144707443) tune Predictor tunables.

        static constexpr int default_rate = 60;

        static constexpr int defaultRate = 60;

        static constexpr auto initial_period =

        static constexpr auto initialPeriod =

                std::chrono::duration<nsecs_t, std::ratio<1, default_rate>>(1);

                std::chrono::duration<nsecs_t, std::ratio<1, defaultRate>>(1);

        static constexpr size_t vsyncTimestampHistorySize = 20;

        static constexpr size_t vsyncTimestampHistorySize = 20;

        static constexpr size_t minimumSamplesForPrediction = 6;

        static constexpr size_t minimumSamplesForPrediction = 6;

        static constexpr uint32_t discardOutlierPercent = 20;

        static constexpr uint32_t discardOutlierPercent = 20;

        auto tracker = std::make_unique<

        auto tracker = std::make_unique<

                scheduler::VSyncPredictor>(std::chrono::duration_cast<std::chrono::nanoseconds>(

                scheduler::VSyncPredictor>(std::chrono::duration_cast<std::chrono::nanoseconds>(

                                                   initial_period)

                                                   initialPeriod)

                                                   .count(),

                                                   .count(),

                                           vsyncTimestampHistorySize, minimumSamplesForPrediction,

                                           vsyncTimestampHistorySize, minimumSamplesForPrediction,

                                           discardOutlierPercent);

                                           discardOutlierPercent);