Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ce764fa8 authored by Jeff Sharkey's avatar Jeff Sharkey
Browse files

Disable APPLY_HARD_QUOTAS in favor of "resgid". 

We're now using the "resgid" filesystem feature to protect users
against abusive apps, so we no longer need to apply hard quotas.

Bug: 77862961
Test: builds, boots
Change-Id: I6877ff93afe9bda3e6039898787240a2b06cdb55
parent 1f0622ed

cmds/installd/InstalldNativeService.cpp

+2 −2
Original line number Diff line number Diff line
@@ -356,8 +356,8 @@ static int prepare_app_dir(const std::string& path, mode_t target_mode, uid_t ui 
 * Ensure that we have a hard-limit quota to protect against abusive apps;

 * they should never use more than 90% of blocks or 50% of inodes.

 */

static int prepare_app_quota(const std::unique_ptr<std::string>& uuid, const std::string& device,

        uid_t uid) {

static int prepare_app_quota(const std::unique_ptr<std::string>& uuid ATTRIBUTE_UNUSED,

        const std::string& device, uid_t uid) {

    // Skip when reserved blocks are protecting us against abusive apps

    if (android::base::GetBoolProperty(kPropHasReserved, false)) return 0;

    // Skip when device no quotas present

cmds/installd/utils.h

+1 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ 
#define BYPASS_QUOTA 0

#define BYPASS_SDCARDFS 0



#define APPLY_HARD_QUOTAS 1

#define APPLY_HARD_QUOTAS 0



namespace android {

namespace installd {