Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ce66b8ad authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: dump dropped oneway transaction data 

oneway transaction errors or parcel contents will be dropped. Whenever
there is an error returned from one of these or data is written to the
parcel, we are now logging it here.

Fixes: 148640588
Test: boot, check logs
Change-Id: I96ad47dc39d6deb03805608ee1b21b090332411a
parent 3c741f03

libs/binder/IPCThreadState.cpp

+5 −0
Original line number Diff line number Diff line
@@ -1230,6 +1230,11 @@ status_t IPCThreadState::executeCommand(int32_t cmd) 
                if (error < NO_ERROR) reply.setError(error);

                sendReply(reply, 0);

            } else {

                if (error != OK || reply.dataSize() != 0) {

                    alog << "oneway function results will be dropped but finished with status "

                         << statusToString(error)

                         << " and parcel size " << reply.dataSize() << endl;

                }

                LOG_ONEWAY("NOT sending reply to %d!", mCallingPid);

            }