Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc41f506 authored by Daniel Nicoara's avatar Daniel Nicoara
Browse files

Check for caller permissions in virtual touchpad service

Bug: 37542947
Test: Compiled and ran on device and verified no permission errors in VR
mode

Change-Id: I8e6198faeeb510792238f6fcce879f6bfb572281
parent 0b4c80ac
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -80,7 +80,6 @@ cc_binary {
    cppflags: ["-std=c++11"],
    cflags: [
        "-DLOG_TAG=\"VrVirtualTouchpad\"",
        "-DSELINUX_ACCESS_CONTROL",
    ],
    host_ldlibs: ["-llog"],
    name: "virtual_touchpad",
+0 −4
Original line number Diff line number Diff line
@@ -122,9 +122,6 @@ bool VirtualTouchpadService::CheckPermissions() {
bool VirtualTouchpadService::CheckTouchPermission(pid_t* out_pid) {
  const android::IPCThreadState* ipc = android::IPCThreadState::self();
  *out_pid = ipc->getCallingPid();
#ifdef SELINUX_ACCESS_CONTROL
  return true;
#else
  const uid_t uid = ipc->getCallingUid();
  const bool permission = PermissionCache::checkPermission(kTouchPermission, *out_pid, uid);
  if (!permission) {
@@ -132,7 +129,6 @@ bool VirtualTouchpadService::CheckTouchPermission(pid_t* out_pid) {
          static_cast<long>(uid));
  }
  return permission;
#endif
}

}  // namespace dvr