Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd95c708 authored by Sergio Giro's avatar Sergio Giro Committed by android-build-merger
Browse files

Merge \"Add bound checks to utf16_to_utf8\" into nyc-mr1-dev

am: 9e3a43e8

Change-Id: Idc968c4efd11de8f3d45499cc8ba094ace605d2f
parents 895b177c 9e3a43e8
Loading
Loading
Loading
Loading
+6 −5
Original line number Diff line number Diff line
@@ -1795,15 +1795,16 @@ status_t Parcel::readUtf8FromUtf16(std::string* str) const {
       return NO_ERROR;
    }

    ssize_t utf8Size = utf16_to_utf8_length(src, utf16Size);
    if (utf8Size < 0) {
    // Allow for closing '\0'
    ssize_t utf8Size = utf16_to_utf8_length(src, utf16Size) + 1;
    if (utf8Size < 1) {
        return BAD_VALUE;
    }
    // Note that while it is probably safe to assume string::resize keeps a
    // spare byte around for the trailing null, we're going to be explicit.
    str->resize(utf8Size + 1);
    utf16_to_utf8(src, utf16Size, &((*str)[0]));
    // spare byte around for the trailing null, we still pass the size including the trailing null
    str->resize(utf8Size);
    utf16_to_utf8(src, utf16Size, &((*str)[0]), utf8Size);
    str->resize(utf8Size - 1);
    return NO_ERROR;
}