Move crop outside of geometry state.
Prior to this CL, if Layer crop is changed while a surface resize is pending, the crop will not be applied until a buffer latches at the new size. This CL makes the crop apply immediately. We can see this is the desired behavior by looking at the two cases where a resize is pending. 1. A resize is pending to make the surface smaller. In this case we need to be able to immediately update the crop so that we can shrink the visible region of the surface at an interactive rate with input. The window manager currently uses big surfaces and scaling modes to accomplish this. 2. A resize is pending to make the surface larger. In this case it doesn't matter. If we expand the crop immediately to the new surface size, then we have simply uncropped an area which is by definition transparent pixels (as we haven't latched a buffer at the new size yet). This change has conceptual soundness as well. We can see that the scaling mode will not affect properties that affect scaling (transform, width/height) but not properties which do not (crop). Bug: 27729195 Bug: 27687126 Change-Id: Ieafdc14aeecb23085793e3056a746d6f344781df
Loading
Please register or sign in to comment