Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4ba8f5c authored by Dominik Laskowski's avatar Dominik Laskowski
Browse files

SF: Fix -Wunused-but-set-variable 

Soong appends -Wno-error=unused-but-set-variable, negating SF's -Werror.

- The type and appId variables are VR remnants.
- TimeStats::canAddNewAggregatedStats compared apples and oranges.

Bug: 129481165
Test: No warnings on clean build
Change-Id: I071e71148a269bf9ab9a5e930a775b4ae6564916
parent 18748965

services/surfaceflinger/BufferLayerConsumer.cpp

+1 −1
Original line number Diff line number Diff line
@@ -438,7 +438,7 @@ void BufferLayerConsumer::onDisconnect() { 
}



void BufferLayerConsumer::onSidebandStreamChanged() {

    FrameAvailableListener* unsafeFrameAvailableListener = nullptr;

    [[maybe_unused]] FrameAvailableListener* unsafeFrameAvailableListener = nullptr;

    {

        Mutex::Autolock lock(mFrameAvailableMutex);

        unsafeFrameAvailableListener = mFrameAvailableListener.unsafe_get();

services/surfaceflinger/Layer.cpp

+0 −14
Original line number Diff line number Diff line
@@ -426,20 +426,6 @@ void Layer::prepareBasicGeometryCompositionState() { 


void Layer::prepareGeometryCompositionState() {

    const auto& drawingState{getDrawingState()};



    int type = drawingState.metadata.getInt32(METADATA_WINDOW_TYPE, 0);

    int appId = drawingState.metadata.getInt32(METADATA_OWNER_UID, 0);

    sp<Layer> parent = mDrawingParent.promote();

    if (parent.get()) {

        auto& parentState = parent->getDrawingState();

        const int parentType = parentState.metadata.getInt32(METADATA_WINDOW_TYPE, 0);

        const int parentAppId = parentState.metadata.getInt32(METADATA_OWNER_UID, 0);

        if (parentType > 0 && parentAppId > 0) {

            type = parentType;

            appId = parentAppId;

        }

    }



    auto* compositionState = editCompositionState();



    compositionState->geomBufferSize = getBufferSize(drawingState);

services/surfaceflinger/TimeStats/TimeStats.cpp

+1 −1
Original line number Diff line number Diff line
@@ -564,7 +564,7 @@ bool TimeStats::canAddNewAggregatedStats(uid_t uid, const std::string& layerName 
        layerRecords += record.second.stats.size();

    }



    return mTimeStats.stats.size() < MAX_NUM_LAYER_STATS;

    return layerRecords < MAX_NUM_LAYER_STATS;

}



void TimeStats::setPostTime(int32_t layerId, uint64_t frameNumber, const std::string& layerName,