Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a2ca9bf0 authored by Dan Stoza's avatar Dan Stoza
Browse files

Revert "libgui: Add getConsumerName" 

This reverts commit 107fbe55.

Change-Id: I0c2b0f7c81193b05eb3dd2f5a59f83598434b744
parent 107fbe55

include/gui/BufferQueueProducer.h

+0 −3
Original line number Diff line number Diff line
@@ -178,9 +178,6 @@ public: 
    // See IGraphicBufferProducer::setGenerationNumber

    virtual status_t setGenerationNumber(uint32_t generationNumber);



    // See IGraphicBufferProducer::getConsumerName

    virtual String8 getConsumerName() const override;



private:

    // This is required by the IBinder::DeathRecipient interface

    virtual void binderDied(const wp<IBinder>& who);

include/gui/IGraphicBufferProducer.h

+0 −3
Original line number Diff line number Diff line
@@ -480,9 +480,6 @@ public: 
    // affected and will retain their current generation number. The generation

    // number defaults to 0.

    virtual status_t setGenerationNumber(uint32_t generationNumber) = 0;



    // Returns the name of the connected consumer.

    virtual String8 getConsumerName() const = 0;

};



// ----------------------------------------------------------------------------

include/gui/Surface.h

+0 −3
Original line number Diff line number Diff line
@@ -106,9 +106,6 @@ public: 
     * See IGBP::setGenerationNumber for more information. */

    status_t setGenerationNumber(uint32_t generationNumber);



    // See IGraphicBufferProducer::getConsumerName

    String8 getConsumerName() const;



protected:

    virtual ~Surface();

libs/gui/BufferQueueProducer.cpp

+0 −6
Original line number Diff line number Diff line
@@ -1089,12 +1089,6 @@ status_t BufferQueueProducer::setGenerationNumber(uint32_t generationNumber) { 
    return NO_ERROR;

}



String8 BufferQueueProducer::getConsumerName() const {

    ATRACE_CALL();

    BQ_LOGV("getConsumerName: %s", mConsumerName.string());

    return mConsumerName;

}



void BufferQueueProducer::binderDied(const wp<android::IBinder>& /* who */) {

    // If we're here, it means that a producer we were connected to died.

    // We're guaranteed that we are still connected to it because we remove

libs/gui/IGraphicBufferProducer.cpp

+0 −17
Original line number Diff line number Diff line
@@ -48,7 +48,6 @@ enum { 
    ALLOCATE_BUFFERS,

    ALLOW_ALLOCATION,

    SET_GENERATION_NUMBER,

    GET_CONSUMER_NAME,

};



class BpGraphicBufferProducer : public BpInterface<IGraphicBufferProducer>
@@ -297,17 +296,6 @@ public: 
        }

        return result;

    }



    virtual String8 getConsumerName() const {

        Parcel data, reply;

        data.writeInterfaceToken(IGraphicBufferProducer::getInterfaceDescriptor());

        status_t result = remote()->transact(GET_CONSUMER_NAME, data, &reply);

        if (result != NO_ERROR) {

            ALOGE("getConsumerName failed to transact: %d", result);

            return String8("TransactFailed");

        }

        return reply.readString8();

    }

};



// Out-of-line virtual method definition to trigger vtable emission in this
@@ -479,11 +467,6 @@ status_t BnGraphicBufferProducer::onTransact( 
            reply->writeInt32(result);

            return NO_ERROR;

        }

        case GET_CONSUMER_NAME: {

            CHECK_INTERFACE(IGraphicBufferProducer, data, reply);

            reply->writeString8(getConsumerName());

            return NO_ERROR;

        }

    }

    return BBinder::onTransact(code, data, reply, flags);

}