Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cb1e6ad authored by Steven Moreland's avatar Steven Moreland
Browse files

binder_parcel_fuzzer: readEnumVector 

These methods were added recently. We can't fuzz them actively because
of b/131868573, but adding them here so that they aren't forgotten.

Fixes: 141999100
Test: run test a few times with these enabled,
    hit oom (didn't hit anything else)

Change-Id: I1dc65b47201f5953fb02269cf421b1f52de306df
parent 264a16a5

libs/binder/fuzzer/binder.cpp

+14 −0
Original line number Diff line number Diff line
@@ -22,6 +22,10 @@ 


using ::android::status_t;



enum ByteEnum : int8_t {};

enum IntEnum : int32_t {};

enum LongEnum : int64_t {};



class ExampleParcelable : public android::Parcelable {

public:

    status_t writeToParcel(android::Parcel* /*parcel*/) const override {
@@ -80,6 +84,7 @@ struct ExampleLightFlattenable : public android::LightFlattenablePod<ExampleLigh 
    PARCEL_READ_WITH_STATUS(T, FUN), \

    PARCEL_READ_NO_STATUS(T, FUN)



// clang-format off

std::vector<ParcelRead<::android::Parcel>> BINDER_PARCEL_READ_FUNCTIONS {

    PARCEL_READ_NO_STATUS(size_t, dataSize),

    PARCEL_READ_NO_STATUS(size_t, dataAvail),
@@ -148,6 +153,14 @@ std::vector<ParcelRead<::android::Parcel>> BINDER_PARCEL_READ_FUNCTIONS { 
    PARCEL_READ_WITH_STATUS(android::sp<android::IBinder>, readStrongBinder),

    PARCEL_READ_WITH_STATUS(android::sp<android::IBinder>, readNullableStrongBinder),



    // TODO(b/131868573): can force read of arbitrarily sized vector

    // PARCEL_READ_WITH_STATUS(std::vector<ByteEnum>, readEnumVector),

    // PARCEL_READ_WITH_STATUS(std::unique_ptr<std::vector<ByteEnum>>, readEnumVector),

    // PARCEL_READ_WITH_STATUS(std::vector<IntEnum>, readEnumVector),

    // PARCEL_READ_WITH_STATUS(std::unique_ptr<std::vector<IntEnum>>, readEnumVector),

    // PARCEL_READ_WITH_STATUS(std::vector<LongEnum>, readEnumVector),

    // PARCEL_READ_WITH_STATUS(std::unique_ptr<std::vector<LongEnum>>, readEnumVector),



    // only reading one parcelable type for now

    // TODO(b/131868573): can force read of arbitrarily sized vector

    // PARCEL_READ_WITH_STATUS(std::unique_ptr<std::vector<std::unique_ptr<ExampleParcelable>>>, readParcelableVector),
@@ -239,3 +252,4 @@ std::vector<ParcelRead<::android::Parcel>> BINDER_PARCEL_READ_FUNCTIONS { 
    PARCEL_READ_NO_STATUS(size_t, getBlobAshmemSize),

    PARCEL_READ_NO_STATUS(size_t, getOpenAshmemSize),

};

// clang-format on