servicemanager: remove performance hack am: d221c251 am: 5eb786d1

#endif  // !VENDORSERVICEMANAGER

ServiceManager::ServiceManager(std::unique_ptr<Access>&& access) : mAccess(std::move(access)) {

#ifndef VENDORSERVICEMANAGER

    // can process these at any times, don't want to delay first VINTF client

    std::thread([] {

        vintf::VintfObject::GetDeviceHalManifest();

        vintf::VintfObject::GetFrameworkHalManifest();

    }).detach();

#endif  // !VENDORSERVICEMANAGER

// TODO(b/151696835): reenable performance hack when we solve bug, since with

//     this hack and other fixes, it is unlikely we will see even an ephemeral

//     failure when the manifest parse fails. The goal is that the manifest will

//     be read incorrectly and cause the process trying to register a HAL to

//     fail. If this is in fact an early boot kernel contention issue, then we

//     will get no failure, and by its absence, be signalled to invest more

//     effort in re-adding this performance hack.

// #ifndef VENDORSERVICEMANAGER

//     // can process these at any times, don't want to delay first VINTF client

//     std::thread([] {

//         vintf::VintfObject::GetDeviceHalManifest();

//         vintf::VintfObject::GetFrameworkHalManifest();

//     }).detach();

// #endif  // !VENDORSERVICEMANAGER

}

ServiceManager::~ServiceManager() {

    // this should only happen in tests