Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9896b3b3 authored by Ady Abraham's avatar Ady Abraham
Browse files

SurfaceFlinger: call setFrameTimelineVsyncForTransaction with valid id 

Remove unnecessary calls to setFrameTimelineVsyncForTransaction when
the vsync id is not valid.

Test: atest SurfaceFlinger_tests
Bug: 171252403
Change-Id: I6233baf5f623c1bc0f3856abb360982c566328ab
parent c89e521b

services/surfaceflinger/SurfaceFlinger.cpp

+1 −3
Original line number Diff line number Diff line
@@ -3787,9 +3787,7 @@ uint32_t SurfaceFlinger::setClientStateLocked( 
    }

    if (what & layer_state_t::eFrameTimelineVsyncChanged) {

        layer->setFrameTimelineVsyncForTransaction(s.frameTimelineVsyncId, postTime);

    } else {

        // TODO (b/171252403) We are calling this too much, potentially triggering

        // unnecessary work

    } else if (frameTimelineVsyncId != ISurfaceComposer::INVALID_VSYNC_ID) {

        layer->setFrameTimelineVsyncForTransaction(frameTimelineVsyncId, postTime);

    }

    if (what & layer_state_t::eFixedTransformHintChanged) {