Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 92c7d70d authored by Narayan Kamath's avatar Narayan Kamath
Browse files

dumpstate: Improve error message for failed dumps. 

Format the header / footer in the same way as successful dumps
and include the PID in the failure message.

Test: Manual
Bug: 118090541
Change-Id: I17f51c816f4d3ebda4cd157b8d05be64008fb81e
parent 6d1dc6ea

cmds/dumpstate/utils.cpp

+5 −1
Original line number Diff line number Diff line
@@ -871,7 +871,11 @@ const char* dump_traces() { 
            is_java_process ? 5 : 20, fd);



        if (ret == -1) {

            dprintf(fd, "dumping failed, likely due to a timeout\n");

            // For consistency, the header and footer to this message match those

            // dumped by debuggerd in the success case.

            dprintf(fd, "\n---- pid %d at [unknown] ----\n", pid);

            dprintf(fd, "Dump failed, likely due to a timeout.\n");

            dprintf(fd, "---- end %d ----", pid);

            timeout_failures++;

            continue;

        }