Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b7acacc authored by Nick Kralevich's avatar Nick Kralevich
Browse files

More O_DIRECTORY | O_NOFOLLOW changes 

Fix a few other spots where we're not using O_NOFOLLOW
with O_DIRECTORY.

Add O_CLOEXEC for good measure.

https://code.google.com/p/android/issues/detail?id=181945

Bug: 23044050
Change-Id: Ib535cbba29cdd587443ea9e1e75831f57fd7a93c
parent a1b2eaa2

cmds/installd/utils.cpp

+3 −3
Original line number Diff line number Diff line
@@ -234,7 +234,7 @@ static int _delete_dir_contents(DIR *d, 
                if ((name[1] == '.') && (name[2] == 0)) continue;

            }



            subfd = openat(dfd, name, O_RDONLY | O_DIRECTORY | O_NOFOLLOW);

            subfd = openat(dfd, name, O_RDONLY | O_DIRECTORY | O_NOFOLLOW | O_CLOEXEC);

            if (subfd < 0) {

                ALOGE("Couldn't openat %s: %s\n", name, strerror(errno));

                result = -1;
@@ -294,7 +294,7 @@ int delete_dir_contents_fd(int dfd, const char *name) 
    int fd, res;

    DIR *d;



    fd = openat(dfd, name, O_RDONLY | O_DIRECTORY);

    fd = openat(dfd, name, O_RDONLY | O_DIRECTORY | O_NOFOLLOW | O_CLOEXEC);

    if (fd < 0) {

        ALOGE("Couldn't openat %s: %s\n", name, strerror(errno));

        return -1;
@@ -634,7 +634,7 @@ static int _add_cache_files(cache_t *cache, cache_dir_t *parentDir, const char * 
                if ((name[1] == '.') && (name[2] == 0)) continue;

            }



            subfd = openat(dfd, name, O_RDONLY | O_DIRECTORY);

            subfd = openat(dfd, name, O_RDONLY | O_DIRECTORY | O_NOFOLLOW | O_CLOEXEC);

            if (subfd < 0) {

                ALOGE("Couldn't openat %s: %s\n", name, strerror(errno));

                continue;