Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 870165d2 authored by Romain Guy's avatar Romain Guy
Browse files

GenerationCache::get would return a random value instead of NULL 

Bug #5401917

This was causing a ton of random crashes in apps.

Change-Id: I9069a060824ec89115cd3bcd38beaeb9ecc4488e
parent 7f5b06e4

include/utils/GenerationCache.h

+4 −2
Original line number Diff line number Diff line
@@ -88,11 +88,13 @@ private: 


    void attachToCache(const sp<Entry<K, V> >& entry);

    void detachFromCache(const sp<Entry<K, V> >& entry);



    const V mNullValue;

}; // class GenerationCache



template<typename K, typename V>

GenerationCache<K, V>::GenerationCache(uint32_t maxCapacity): mMaxCapacity(maxCapacity),

    mListener(NULL) {

    mListener(NULL), mNullValue(NULL) {

};



template<typename K, typename V>
@@ -154,7 +156,7 @@ const V& GenerationCache<K, V>::get(const K& key) { 
        return entry->value;

    }



    return NULL;

    return mNullValue;

}



template<typename K, typename V>