Commit 84d077cb authored Dec 20, 2019 by Dan Zimmerman Committed by Mathieu Chartier Feb 07, 2020

[dexopt] Allow secondary dex files to generate app images

After creating tests and fixing bugs surrounding loading multiple app
images into the runtime we can safely enable generating app image files
for secondary dexes.

Test: adb shell pm bg-dexopt-job with app installed that uses secondary
dexes, verify app image is generated for secondary image. Launch app and
verify no class linker/class loader/image space warnings in logcat
Bug: 149098478

Change-Id: Iaa04175ee56aae69f41f3e2972c322049cfc9e26

parent 26d0eb32

cmds/installd/dexopt.cpp

+0 −5

Original line number	Diff line number	Diff line
		@@ -1271,11 +1271,6 @@ class Dex2oatFileWrapper {
		Dex2oatFileWrapper maybe_open_app_image(const char* out_oat_path,
		bool generate_app_image, bool is_public, int uid, bool is_secondary_dex) {

		// We don't create an image for secondary dex files.
		if (is_secondary_dex) {
		return Dex2oatFileWrapper();
		}

		const std::string image_path = create_image_filename(out_oat_path);
		if (image_path.empty()) {
		// Happens when the out_oat_path has an unknown extension.