Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82607f30 authored by John Reck's avatar John Reck
Browse files

Fix BufferItemConsumer::releaseBuffer error logging

STALE_BUFFER_SLOT is a hint, not an error, and shouldn't
be logged.

Fixes: 77483431
Test: verified
CtsUiRenderingTestCases:.testclasses.HardwareBitmapTests#testCreateFromPicture
doesn't log any errors to logcat

Change-Id: I570c585b7c55c668d994bf37854a2252b09b9da8
parent 13487078
Loading
Loading
Loading
Loading
+4 −1
Original line number Diff line number Diff line
@@ -92,10 +92,13 @@ status_t BufferItemConsumer::releaseBuffer(const BufferItem &item,
    Mutex::Autolock _l(mMutex);

    err = addReleaseFenceLocked(item.mSlot, item.mGraphicBuffer, releaseFence);
    if (err != OK) {
        BI_LOGE("Failed to addReleaseFenceLocked");
    }

    err = releaseBufferLocked(item.mSlot, item.mGraphicBuffer, EGL_NO_DISPLAY,
            EGL_NO_SYNC_KHR);
    if (err != OK) {
    if (err != OK && err != IGraphicBufferConsumer::STALE_BUFFER_SLOT) {
        BI_LOGE("Failed to release buffer: %s (%d)",
                strerror(-err), err);
    }