Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b09e799 authored by Francis Hart's avatar Francis Hart
Browse files

Surface: Use async lock/unlock in copyBlt 

The Surface::lock() function now uses the asynchronous versions of
gralloc lock/unlock when copying the previously drawn content to the
backbuffer. This allows for optimisations in the gralloc module
implementation and so can improve performance and avoid CPU waits.

Change-Id: I57193f327db2ff0422e1b58b3484f613201d994c
parent b7ee96a6

libs/gui/Surface.cpp

+7 −17
Original line number Diff line number Diff line
@@ -20,13 +20,6 @@ 


#include <android/native_window.h>



// We would eliminate the non-conforming zero-length array, but we can't since

// this is effectively included from the Linux kernel

#pragma clang diagnostic push

#pragma clang diagnostic ignored "-Wzero-length-array"

#include <sync/sync.h>

#pragma clang diagnostic pop



#include <binder/Parcel.h>



#include <utils/Log.h>
@@ -1179,7 +1172,8 @@ void Surface::setSurfaceDamage(android_native_rect_t* rects, size_t numRects) { 
static status_t copyBlt(

        const sp<GraphicBuffer>& dst,

        const sp<GraphicBuffer>& src,

        const Region& reg)

        const Region& reg,

        int *dstFenceFd)

{

    // src and dst with, height and format must be identical. no verification

    // is done here.
@@ -1190,9 +1184,10 @@ static status_t copyBlt( 
    ALOGE_IF(err, "error locking src buffer %s", strerror(-err));



    uint8_t* dst_bits = NULL;

    err = dst->lock(GRALLOC_USAGE_SW_WRITE_OFTEN, reg.bounds(),

            reinterpret_cast<void**>(&dst_bits));

    err = dst->lockAsync(GRALLOC_USAGE_SW_WRITE_OFTEN, reg.bounds(),

            reinterpret_cast<void**>(&dst_bits), *dstFenceFd);

    ALOGE_IF(err, "error locking dst buffer %s", strerror(-err));

    *dstFenceFd = -1;



    Region::const_iterator head(reg.begin());

    Region::const_iterator tail(reg.end());
@@ -1226,7 +1221,7 @@ static status_t copyBlt( 
        src->unlock();



    if (dst_bits)

        dst->unlock();

        dst->unlockAsync(dstFenceFd);



    return err;

}
@@ -1277,12 +1272,7 @@ status_t Surface::lock( 
            // copy the area that is invalid and not repainted this round

            const Region copyback(mDirtyRegion.subtract(newDirtyRegion));

            if (!copyback.isEmpty()) {

                if (fenceFd >= 0) {

                    sync_wait(fenceFd, -1);

                    close(fenceFd);

                    fenceFd = -1;

                }

                copyBlt(backBuffer, frontBuffer, copyback);

                copyBlt(backBuffer, frontBuffer, copyback, &fenceFd);

            }

        } else {

            // if we can't copy-back anything, modify the user's dirty