Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 734e378a authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Use -Werror in frameworks/native/cmds 

* Remove or comment out unused variables/functions.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I15a463eb9a20bc12787c104f671063ceeafaa1cc
parent c1e25bd5

cmds/atrace/Android.bp

+4 −0
Original line number Diff line number Diff line
@@ -3,6 +3,10 @@ 
cc_binary {

    name: "atrace",

    srcs: ["atrace.cpp"],

    cflags: [

        "-Wall",

        "-Werror",

    ],



    shared_libs: [

        "libbinder",

cmds/atrace/atrace.cpp

+6 −4
Original line number Diff line number Diff line
@@ -216,8 +216,11 @@ static const char* k_traceClockPath = 
static const char* k_traceBufferSizePath =

    "buffer_size_kb";



#if 0

// TODO: Re-enable after stabilization

static const char* k_traceCmdlineSizePath =

    "saved_cmdlines_size";

#endif



static const char* k_tracingOverwriteEnablePath =

    "options/overwrite";
@@ -240,9 +243,6 @@ static const char* k_funcgraphProcPath = 
static const char* k_funcgraphFlatPath =

    "options/funcgraph-flat";



static const char* k_funcgraphDurationPath =

    "options/funcgraph-duration";



static const char* k_ftraceFilterPath =

    "set_ftrace_filter";
@@ -431,7 +431,6 @@ static bool clearTrace() 
static bool setTraceBufferSizeKB(int size)

{

    char str[32] = "1";

    int len;

    if (size < 1) {

        size = 1;

    }
@@ -439,6 +438,8 @@ static bool setTraceBufferSizeKB(int size) 
    return writeStr(k_traceBufferSizePath, str);

}



#if 0

// TODO: Re-enable after stabilization

// Set the default size of cmdline hashtable

static bool setCmdlineSize()

{
@@ -447,6 +448,7 @@ static bool setCmdlineSize() 
    }

    return true;

}

#endif



// Set the clock to the best available option while tracing. Use 'boot' if it's

// available; otherwise, use 'mono'. If neither are available use 'global'.

cmds/bugreport/Android.bp

+1 −1
Original line number Diff line number Diff line 
cc_binary {

    name: "bugreport",

    srcs: ["bugreport.cpp"],

    cflags: ["-Wall"],

    cflags: ["-Wall", "-Werror"],

    shared_libs: ["libcutils"],

}

cmds/dumpsys/tests/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -4,6 +4,7 @@ cc_test { 
    test_suites: ["device-tests"],



    srcs: ["dumpsys_test.cpp"],

    cflags: ["-Wall", "-Werror"],



    shared_libs: [

        "libbase",

cmds/installd/tests/Android.bp

+3 −0
Original line number Diff line number Diff line
@@ -3,6 +3,7 @@ cc_test { 
    name: "installd_utils_test",

    clang: true,

    srcs: ["installd_utils_test.cpp"],

    cflags: ["-Wall", "-Werror"],

    shared_libs: [

        "libbase",

        "liblog",
@@ -19,6 +20,7 @@ cc_test { 
    name: "installd_cache_test",

    clang: true,

    srcs: ["installd_cache_test.cpp"],

    cflags: ["-Wall", "-Werror"],

    shared_libs: [

        "libbase",

        "libbinder",
@@ -38,6 +40,7 @@ cc_test { 
    name: "installd_service_test",

    clang: true,

    srcs: ["installd_service_test.cpp"],

    cflags: ["-Wall", "-Werror"],

    shared_libs: [

        "libbase",

        "libbinder",