Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d758fc4 authored by Greg Kaiser's avatar Greg Kaiser
Browse files

installd: Avoid extra std::string copy 

The method is_valid_package_name() takes a const std::string
reference, so it's inefficient to pass a std::string::c_str().

Test: TreeHugger
Change-Id: Ic8b33ce8b6c664f960b5c84f688821e9f7eddf03
parent 8042c37f

cmds/installd/InstalldNativeService.cpp

+1 −1
Original line number Diff line number Diff line
@@ -180,7 +180,7 @@ binder::Status checkArgumentUuidTestOrNull(const std::unique_ptr<std::string>& u 
}



binder::Status checkArgumentPackageName(const std::string& packageName) {

    if (is_valid_package_name(packageName.c_str())) {

    if (is_valid_package_name(packageName)) {

        return ok();

    } else {

        return exception(binder::Status::EX_ILLEGAL_ARGUMENT,