Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6896f062 authored by Stephen Hines's avatar Stephen Hines
Browse files

NFC: Directly initialize the 's' variable. 

As part of enabling -Wconditional-uninitialized, there are some false
positives. See https://bugs.llvm.org/show_bug.cgi?id=38856 for more info
about the limited flow analysis. To facilitate turning this flag on more
widely, we can just directly initialize these variables.

Bug: http://b/131390872
Test: Builds with -Wconditional-uninitialized.
Change-Id: Id6633a06478dfb0c51a1a3b0cabf4c4e5d57abaa
parent 67923215

cmds/bugreport/bugreport.cpp

+1 −1
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ int main() { 
  property_set("ctl.start", "dumpstate");



  // Socket will not be available until service starts.

  int s;

  int s = -1;

  for (int i = 0; i < 20; i++) {

    s = socket_local_client("dumpstate", ANDROID_SOCKET_NAMESPACE_RESERVED,

                            SOCK_STREAM);

cmds/bugreportz/main.cpp

+1 −1
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ int main(int argc, char* argv[]) { 
    property_set("ctl.start", "dumpstatez");



    // Socket will not be available until service starts.

    int s;

    int s = -1;

    for (int i = 0; i < 20; i++) {

        s = socket_local_client("dumpstate", ANDROID_SOCKET_NAMESPACE_RESERVED, SOCK_STREAM);

        if (s >= 0) break;