Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6183eb72 authored by Bernhard Rosenkränzer's avatar Bernhard Rosenkränzer
Browse files

Remove comparisons that can't be true 



keyBitmask and ledBitmask are arrays, "!their address" always evaluates to
false. clang complains about this.

Change-Id: I6aed45a203b0eeaad2093dbdebea03a2c2fc1a3d
Signed-off-by: default avatarBernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
parent 55f71bc0

services/inputflinger/EventHub.cpp

+2 −2
Original line number Diff line number Diff line
@@ -1443,7 +1443,7 @@ void EventHub::setLedForController(Device* device) { 
}



bool EventHub::hasKeycodeLocked(Device* device, int keycode) const {

    if (!device->keyMap.haveKeyLayout() || !device->keyBitmask) {

    if (!device->keyMap.haveKeyLayout()) {

        return false;

    }
@@ -1461,7 +1461,7 @@ bool EventHub::hasKeycodeLocked(Device* device, int keycode) const { 
}



status_t EventHub::mapLed(Device* device, int32_t led, int32_t* outScanCode) const {

    if (!device->keyMap.haveKeyLayout() || !device->ledBitmask) {

    if (!device->keyMap.haveKeyLayout()) {

        return NAME_NOT_FOUND;

    }