Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f619937 authored by Bernhard Rosenkränzer's avatar Bernhard Rosenkränzer Committed by Chih-Hung Hsieh
Browse files

Fix potential format string vulnerability 



A sensor name containing a format string could have interesting side
effects...

Change-Id: If7f1378aa68572d9716c339728eab18faa6b9f2a
Signed-off-by: default avatarBernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
parent 2e42a906

services/sensorservice/SensorService.cpp

+3 −6
Original line number Diff line number Diff line
@@ -617,12 +617,9 @@ Vector<Sensor> SensorService::getSensorList() 
        if (canAccessSensor(sensor)) {

            accessibleSensorList.add(sensor);

        } else {

            String8 infoMessage;

            infoMessage.appendFormat(

                    "Skipped sensor %s because it requires permission %s",

            ALOGI("Skipped sensor %s because it requires permission %s",

                  sensor.getName().string(),

                  sensor.getRequiredPermission().string());

            ALOGI(infoMessage.string());

        }

    }

    return accessibleSensorList;