Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5df47cb6 authored by Dan Stoza's avatar Dan Stoza
Browse files

HWC2On1: Fall back to GLES for SolidColor 

Even though SolidColor layers map cleanly to HWC_BACKGROUND composition
in HWC1, SurfaceFlinger never used HWC_BACKGROUND, so we can't trust
that HWC1 devices implemented it correctly. To preserve backwards
compatibility, this changes the behavior to fall back to client
composition to minimize incompatibilities with existing devices.

Bug: 30479781
Change-Id: I638339062e03f2c057b3e1624e7157587ddee7ec
parent 186c4c93

services/surfaceflinger/DisplayHardware/HWC2On1Adapter.cpp

+8 −1
Original line number Diff line number Diff line
@@ -2305,7 +2305,14 @@ void HWC2On1Adapter::Layer::applyCompositionType(hwc_layer_1_t& hwc1Layer, 
                hwc1Layer.compositionType = HWC_FRAMEBUFFER;

                break;

            case Composition::SolidColor:

                hwc1Layer.compositionType = HWC_BACKGROUND;

                // In theory the following line should work, but since the HWC1

                // version of SurfaceFlinger never used HWC_BACKGROUND, HWC1

                // devices may not work correctly. To be on the safe side, we

                // fall back to client composition.

                //

                // hwc1Layer.compositionType = HWC_BACKGROUND;

                hwc1Layer.compositionType = HWC_FRAMEBUFFER;

                hwc1Layer.flags |= HWC_SKIP_LAYER;

                break;

            case Composition::Cursor:

                hwc1Layer.compositionType = HWC_FRAMEBUFFER;