Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 598f6d54 authored by Steve Pfetsch's avatar Steve Pfetsch
Browse files

Revert "services: surfaceflinger: ASAN fix" 

This reverts commit 1d3df546.

Original patch may have caused a stability issue caught in monkey testing.

Bug: 32312240
Change-Id: Ie8d291679590e624b8b90c4786b1c25c76cb2c9f
parent 1d3df546

services/surfaceflinger/SurfaceFlinger.cpp

+9 −8
Original line number Diff line number Diff line
@@ -1768,12 +1768,9 @@ void SurfaceFlinger::updateCursorAsync() 


void SurfaceFlinger::commitTransaction()

{

    sp<const DisplayDevice> hw = getDefaultDisplayDevice();



    if (!mLayersPendingRemoval.isEmpty() && hw->isDisplayOn()) {

    if (!mLayersPendingRemoval.isEmpty()) {

        // Notify removed layers now that they can't be drawn from

        for (size_t i = 0; i < mLayersPendingRemoval.size(); i++) {

            mCurrentState.layersSortedByZ.remove(mLayersPendingRemoval[i]);

            recordBufferingStats(mLayersPendingRemoval[i]->getName().string(),

                    mLayersPendingRemoval[i]->getOccupancyHistory(true));

            mLayersPendingRemoval[i]->onRemoved();
@@ -2220,11 +2217,15 @@ status_t SurfaceFlinger::removeLayer(const wp<Layer>& weakLayer) { 
        return NO_ERROR;

    }



    ssize_t index = mCurrentState.layersSortedByZ.remove(layer);

    if (index >= 0) {

        mLayersPendingRemoval.push(layer);

        mLayersRemoved = true;

        setTransactionFlags(eTransactionNeeded);

        return NO_ERROR;

    }

    return status_t(index);

}



uint32_t SurfaceFlinger::peekTransactionFlags(uint32_t /* flags */) {

    return android_atomic_release_load(&mTransactionFlags);