Loading libs/vr/libpdx/status_tests.cpp +5 −3 Original line number Diff line number Diff line Loading @@ -2,6 +2,8 @@ #include <gtest/gtest.h> #include <memory> using android::pdx::ErrorStatus; using android::pdx::Status; Loading Loading @@ -84,8 +86,8 @@ TEST(Status, Move) { Status<std::unique_ptr<int>> status1; Status<std::unique_ptr<int>> status2; status1 = Status<std::unique_ptr<int>>{std::unique_ptr<int>{new int{11}}}; status2 = Status<std::unique_ptr<int>>{std::unique_ptr<int>{new int{12}}}; status1 = Status<std::unique_ptr<int>>{std::make_unique<int>(int{11})}; status2 = Status<std::unique_ptr<int>>{std::make_unique<int>(int{12})}; EXPECT_FALSE(status1.empty()); EXPECT_FALSE(status2.empty()); EXPECT_TRUE(status1.ok()); Loading Loading @@ -114,7 +116,7 @@ TEST(Status, Move) { } TEST(Status, Take) { Status<std::unique_ptr<int>> status{std::unique_ptr<int>{new int{123}}}; Status<std::unique_ptr<int>> status{std::make_unique<int>(int{123})}; EXPECT_FALSE(status.empty()); EXPECT_NE(nullptr, status.get()); Loading services/vr/hardware_composer/impl/vr_composer_client.cpp +3 −1 Original line number Diff line number Diff line Loading @@ -19,6 +19,8 @@ #include <hardware/gralloc1.h> #include <log/log.h> #include <memory> #include "impl/vr_hwc.h" #include "impl/vr_composer_client.h" Loading @@ -39,7 +41,7 @@ VrComposerClient::~VrComposerClient() {} std::unique_ptr<ComposerCommandEngine> VrComposerClient::createCommandEngine() { return std::unique_ptr<VrCommandEngine>(new VrCommandEngine(*this)); return std::make_unique<VrCommandEngine>(*this); } VrComposerClient::VrCommandEngine::VrCommandEngine(VrComposerClient& client) Loading Loading
libs/vr/libpdx/status_tests.cpp +5 −3 Original line number Diff line number Diff line Loading @@ -2,6 +2,8 @@ #include <gtest/gtest.h> #include <memory> using android::pdx::ErrorStatus; using android::pdx::Status; Loading Loading @@ -84,8 +86,8 @@ TEST(Status, Move) { Status<std::unique_ptr<int>> status1; Status<std::unique_ptr<int>> status2; status1 = Status<std::unique_ptr<int>>{std::unique_ptr<int>{new int{11}}}; status2 = Status<std::unique_ptr<int>>{std::unique_ptr<int>{new int{12}}}; status1 = Status<std::unique_ptr<int>>{std::make_unique<int>(int{11})}; status2 = Status<std::unique_ptr<int>>{std::make_unique<int>(int{12})}; EXPECT_FALSE(status1.empty()); EXPECT_FALSE(status2.empty()); EXPECT_TRUE(status1.ok()); Loading Loading @@ -114,7 +116,7 @@ TEST(Status, Move) { } TEST(Status, Take) { Status<std::unique_ptr<int>> status{std::unique_ptr<int>{new int{123}}}; Status<std::unique_ptr<int>> status{std::make_unique<int>(int{123})}; EXPECT_FALSE(status.empty()); EXPECT_NE(nullptr, status.get()); Loading
services/vr/hardware_composer/impl/vr_composer_client.cpp +3 −1 Original line number Diff line number Diff line Loading @@ -19,6 +19,8 @@ #include <hardware/gralloc1.h> #include <log/log.h> #include <memory> #include "impl/vr_hwc.h" #include "impl/vr_composer_client.h" Loading @@ -39,7 +41,7 @@ VrComposerClient::~VrComposerClient() {} std::unique_ptr<ComposerCommandEngine> VrComposerClient::createCommandEngine() { return std::unique_ptr<VrCommandEngine>(new VrCommandEngine(*this)); return std::make_unique<VrCommandEngine>(*this); } VrComposerClient::VrCommandEngine::VrCommandEngine(VrComposerClient& client) Loading