Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 487340f0 authored by Yiwei Zhang's avatar Yiwei Zhang
Browse files

TimeStats: make sure acquire fence is captured 

Previously, if setAcquireFence happens earlier than setPostTime, the
acquire fence is not recorded in TimeStats which ends up with acquire
time being the same with post time. This issue is almost eliminated
after a previous refactoring of the order of recording TimeStats and
EGL throttling logic.

Since acquire fence is already available at post time, this change just
captures that by then to avoid any chance of missing the acquire fence.

Bug: 140266250
Test: atest libsurfaceflinger_unittest:TimeStatsTest
Change-Id: I90a5ab609afc7054c618273c3af79c9d12d85730
parent d3df1b34

services/surfaceflinger/BufferQueueLayer.cpp

+0 −2
Original line number Diff line number Diff line
@@ -307,8 +307,6 @@ status_t BufferQueueLayer::updateTexImage(bool& recomputeVisibleRegions, nsecs_t 
        }



        uint64_t bufferID = mQueueItems[0].mGraphicBuffer->getId();

        mFlinger->mTimeStats->setAcquireFence(layerId, currentFrameNumber,

                                              mQueueItems[0].mFenceTime);

        mFlinger->mFrameTracer->traceFence(layerId, bufferID, currentFrameNumber,

                                           mQueueItems[0].mFenceTime,

                                           FrameTracer::FrameEvent::ACQUIRE_FENCE);

services/surfaceflinger/Layer.cpp

+2 −0
Original line number Diff line number Diff line
@@ -1370,6 +1370,8 @@ void Layer::addAndGetFrameTimestamps(const NewFrameEventsEntry* newTimestamps, 
    if (newTimestamps) {

        mFlinger->mTimeStats->setPostTime(getSequence(), newTimestamps->frameNumber,

                                          getName().c_str(), newTimestamps->postedTime);

        mFlinger->mTimeStats->setAcquireFence(getSequence(), newTimestamps->frameNumber,

                                              newTimestamps->acquireFence);

    }



    Mutex::Autolock lock(mFrameEventHistoryMutex);