Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d095726 authored by David Sodman's avatar David Sodman
Browse files

SF: Fix initialization of mRefreshStartTime 

Commit 64a0427a introduced a bug
by re-arranging code in FE and BE by initializing mRefreshStartTime
in beginFrame which is invoked after preComposition, which is the
first place it is referenced.   This change moves the initialization
to be prior to usage.

Bug: 111647590
Test: run cts -m CtsDeqpTestCases, run cts -m CtsViewTestCases
Change-Id: Ia9856d5aafd668c78f0741979b472af830276e6e
parent d7e01d70

services/surfaceflinger/SurfaceFlinger.cpp

+2 −2
Original line number Diff line number Diff line
@@ -1765,6 +1765,8 @@ void SurfaceFlinger::preComposition() 
    ATRACE_CALL();

    ALOGV("preComposition");



    mRefreshStartTime = systemTime(SYSTEM_TIME_MONOTONIC);



    bool needExtraInvalidate = false;

    mDrawingState.traverseInZOrder([&](Layer* layer) {

        if (layer->onPreComposition(mRefreshStartTime)) {
@@ -2218,8 +2220,6 @@ void SurfaceFlinger::configureDeviceComposition(const CompositionInfo& compositi 


void SurfaceFlinger::beginFrame()

{

    mRefreshStartTime = systemTime(SYSTEM_TIME_MONOTONIC);



    for (const auto& [token, display] : mDisplays) {

        bool dirty = !display->getDirtyRegion(mRepaintEverything).isEmpty();

        bool empty = display->getVisibleLayersSortedByZ().size() == 0;