Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c95f2da authored by Nicolas Geoffray's avatar Nicolas Geoffray
Browse files

Revert "Disable input-vdex when doing speed-profile." 

https://android-review.googlesource.com/#/c/377754/ is fixing vdex and delayout.

bug: 37558732
Test: device boots, vdex works on OTA, input-vdex is passed
      for speed-profile

This reverts commit a2dbefc7.

Change-Id: I8fcab30ec617b39769fbf7e5818e5d503d647fb4
parent a2dbefc7

cmds/installd/dexopt.cpp

+5 −7
Original line number Diff line number Diff line
@@ -1105,8 +1105,8 @@ Dex2oatFileWrapper maybe_open_reference_profile(const char* pkgname, bool profil 
// Opens the vdex files and assigns the input fd to in_vdex_wrapper_fd and the output fd to

// out_vdex_wrapper_fd. Returns true for success or false in case of errors.

bool open_vdex_files(const char* apk_path, const char* out_oat_path, int dexopt_needed,

        const char* instruction_set, bool is_public, bool profile_guided,

        int uid, bool is_secondary_dex, Dex2oatFileWrapper* in_vdex_wrapper_fd,

        const char* instruction_set, bool is_public, int uid, bool is_secondary_dex,

        Dex2oatFileWrapper* in_vdex_wrapper_fd,

        Dex2oatFileWrapper* out_vdex_wrapper_fd) {

    CHECK(in_vdex_wrapper_fd != nullptr);

    CHECK(out_vdex_wrapper_fd != nullptr);
@@ -1116,9 +1116,7 @@ bool open_vdex_files(const char* apk_path, const char* out_oat_path, int dexopt_ 
    int dexopt_action = abs(dexopt_needed);

    bool is_odex_location = dexopt_needed < 0;

    std::string in_vdex_path_str;

    // Disable passing an input vdex when the compilation is profile-guided. The dexlayout

    // optimization in dex2oat is incompatible with it. b/35872504.

    if (dexopt_action != DEX2OAT_FROM_SCRATCH && !profile_guided) {

    if (dexopt_action != DEX2OAT_FROM_SCRATCH) {

        // Open the possibly existing vdex. If none exist, we pass -1 to dex2oat for input-vdex-fd.

        const char* path = nullptr;

        if (is_odex_location) {
@@ -1451,8 +1449,8 @@ int dexopt(const char* dex_path, uid_t uid, const char* pkgname, const char* ins 
    // Open vdex files.

    Dex2oatFileWrapper in_vdex_fd;

    Dex2oatFileWrapper out_vdex_fd;

    if (!open_vdex_files(dex_path, out_oat_path, dexopt_needed, instruction_set, is_public,

            profile_guided, uid, is_secondary_dex, &in_vdex_fd, &out_vdex_fd)) {

    if (!open_vdex_files(dex_path, out_oat_path, dexopt_needed, instruction_set, is_public, uid,

            is_secondary_dex, &in_vdex_fd, &out_vdex_fd)) {

        return -1;

    }