Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38a11928 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Use -Werror in frameworks/native/libs/vr 

* Suppress/fix warnings of unused variable, parameter,
  private-field, and function.
* Fix warnings about typedef missing declarator.
* Use -Wno-error to keep existing warnings, to fix later.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Ifb82fcd76fcb5d9c9d9f017f2541581661493bd5
parent 6cfabaeb

libs/vr/libbufferhub/Android.bp

+8 −0
Original line number Diff line number Diff line
@@ -42,6 +42,9 @@ cc_library { 
        "-DLOG_TAG=\"libbufferhub\"",

        "-DTRACE=0",

        "-DATRACE_TAG=ATRACE_TAG_GRAPHICS",

        "-Wall",

        "-Werror",

        "-Wno-error=sign-compare", // to fix later

    ],

    export_include_dirs: localIncludeFiles,

    static_libs: staticLibraries,
@@ -55,5 +58,10 @@ cc_test { 
    static_libs: ["libbufferhub"] + staticLibraries,

    shared_libs: sharedLibraries,

    name: "bufferhub_tests",

    cflags: [

        "-Wall",

        "-Werror",

        "-Wno-error=sign-compare", // to fix later

    ],

}

libs/vr/libbufferhubqueue/Android.bp

+5 −0
Original line number Diff line number Diff line
@@ -48,6 +48,11 @@ cc_library { 
        "-DLOG_TAG=\"libbufferhubqueue\"",

        "-DTRACE=0",

        "-DATRACE_TAG=ATRACE_TAG_GRAPHICS",

        "-Wall",

        "-Werror",

        "-Wno-error=sign-compare", // to fix later

        "-Wno-unused-parameter",

        "-Wno-unused-variable",

    ],

    srcs: sourceFiles,

    export_include_dirs: includeFiles,

libs/vr/libbufferhubqueue/tests/Android.bp

+6 −0
Original line number Diff line number Diff line
@@ -28,6 +28,9 @@ cc_test { 
        "-DTRACE=0",

        "-O0",

        "-g",

        "-Wall",

        "-Werror",

        "-Wno-error=sign-compare", // to fix later

    ],

    name: "buffer_hub_queue-test",

    tags: ["optional"],
@@ -42,6 +45,9 @@ cc_test { 
        "-DTRACE=0",

        "-O0",

        "-g",

        "-Wall",

        "-Werror",

        "-Wno-error=sign-compare", // to fix later

    ],

    name: "buffer_hub_queue_producer-test",

    tags: ["optional"],

libs/vr/libdisplay/Android.bp

+2 −0
Original line number Diff line number Diff line
@@ -55,6 +55,8 @@ cc_library { 
        "-DATRACE_TAG=ATRACE_TAG_GRAPHICS",

        "-DGL_GLEXT_PROTOTYPES",

        "-DEGL_EGLEXT_PROTOTYPES",

        "-Wall",

        "-Werror",

    ],  // + [ "-UNDEBUG", "-DDEBUG", "-O0", "-g" ],

    export_include_dirs: localIncludeFiles,

    shared_libs: sharedLibraries,

libs/vr/libdisplay/include/dvr/dvr_display_types.h

+1 −1
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ __BEGIN_DECLS 
#ifndef __FLOAT32X4T_86

#define __FLOAT32X4T_86

typedef float float32x4_t __attribute__((__vector_size__(16)));

typedef struct float32x4x4_t { float32x4_t val[4]; };

typedef struct float32x4x4_t { float32x4_t val[4]; } float32x4x4_t;

#endif

#endif