Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b437b27 authored by Nate Myren's avatar Nate Myren
Browse files

Properly unparcel return from note/startOperation 

still to do: replace manual unparcelling with a C++ SyncNotedAppOp class
Fixes: 184695771
Test: atest AppOpsLoggingTest

Change-Id: Id1d9e72d9b2e5ba74b4782ca8d014235cf8513a1
parent 0de23a9e

libs/binder/IAppOpsService.cpp

+5 −1
Original line number Diff line number Diff line
@@ -18,8 +18,8 @@ 


#include <binder/IAppOpsService.h>



#include <utils/Log.h>

#include <binder/Parcel.h>

#include <utils/Log.h>

#include <utils/String8.h>



#include <optional>
@@ -63,6 +63,8 @@ public: 
        remote()->transact(NOTE_OPERATION_TRANSACTION, data, &reply);

        // fail on exception

        if (reply.readExceptionCode() != 0) return MODE_ERRORED;

        // TODO b/184855056: extract to class

        reply.readInt32();

        reply.readByte();

        return reply.readInt32();

    }
@@ -85,6 +87,8 @@ public: 
        remote()->transact(START_OPERATION_TRANSACTION, data, &reply);

        // fail on exception

        if (reply.readExceptionCode() != 0) return MODE_ERRORED;

        // TODO b/184855056: extract to class

        reply.readInt32();

        reply.readByte();

        return reply.readInt32();

    }