Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b2bbd39 authored by Alec Mouri's avatar Alec Mouri Committed by Ana Krulec
Browse files

[SurfaceFlinger] correct present time for negative phase offsets 

DispSync::expectedPresentTime returns the expected presentation time for
the current frame, but when we're in negative offsets we are targetting
the following frame instead.

Bug: 133241520
Bug: 134589085
Test: systrace when flinging through news
Change-Id: I7cc05a0b9e8e9b5c3e8d0c4b1d59b0a7dabd43d4
Merged-In: I7cc05a0b9e8e9b5c3e8d0c4b1d59b0a7dabd43d4
parent 1265a906

services/surfaceflinger/BufferQueueLayer.cpp

+1 −1
Original line number Original line Diff line number Diff line
@@ -143,7 +143,7 @@ bool BufferQueueLayer::framePresentTimeIsCurrent() const { 
    }

    }





    Mutex::Autolock lock(mQueueItemLock);

    Mutex::Autolock lock(mQueueItemLock);

    return mQueueItems[0].mTimestamp <= mFlinger->mScheduler->expectedPresentTime();

    return mQueueItems[0].mTimestamp <= mFlinger->getExpectedPresentTime();

}

}





nsecs_t BufferQueueLayer::getDesiredPresentTime() {

nsecs_t BufferQueueLayer::getDesiredPresentTime() {

services/surfaceflinger/BufferStateLayer.cpp

+1 −1
Original line number Original line Diff line number Diff line
@@ -380,7 +380,7 @@ bool BufferStateLayer::framePresentTimeIsCurrent() const { 
        return true;

        return true;

    }

    }





    return mDesiredPresentTime <= mFlinger->mScheduler->expectedPresentTime();

    return mDesiredPresentTime <= mFlinger->getExpectedPresentTime();

}

}





nsecs_t BufferStateLayer::getDesiredPresentTime() {

nsecs_t BufferStateLayer::getDesiredPresentTime() {

services/surfaceflinger/SurfaceFlinger.cpp

+13 −2
Original line number Original line Diff line number Diff line
@@ -1655,6 +1655,18 @@ bool SurfaceFlinger::previousFrameMissed() NO_THREAD_SAFETY_ANALYSIS { 
    return fence != Fence::NO_FENCE && (fence->getStatus() == Fence::Status::Unsignaled);

    return fence != Fence::NO_FENCE && (fence->getStatus() == Fence::Status::Unsignaled);

}

}





nsecs_t SurfaceFlinger::getExpectedPresentTime() NO_THREAD_SAFETY_ANALYSIS {

    DisplayStatInfo stats;

    mScheduler->getDisplayStatInfo(&stats);

    const nsecs_t presentTime = mScheduler->expectedPresentTime();

    // Inflate the expected present time if we're targetting the next vsync.

    const nsecs_t correctedTime =

            mVsyncModulator.getOffsets().sf < mPhaseOffsets->getOffsetThresholdForNextVsync()

            ? presentTime

            : presentTime + stats.vsyncPeriod;

    return correctedTime;

}



void SurfaceFlinger::onMessageReceived(int32_t what) NO_THREAD_SAFETY_ANALYSIS {

void SurfaceFlinger::onMessageReceived(int32_t what) NO_THREAD_SAFETY_ANALYSIS {

    ATRACE_CALL();

    ATRACE_CALL();

    switch (what) {

    switch (what) {
@@ -3263,8 +3275,7 @@ bool SurfaceFlinger::handlePageFlip() 
    mDrawingState.traverseInZOrder([&](Layer* layer) {

    mDrawingState.traverseInZOrder([&](Layer* layer) {

        if (layer->hasReadyFrame()) {

        if (layer->hasReadyFrame()) {

            frameQueued = true;

            frameQueued = true;

            nsecs_t expectedPresentTime;

            const nsecs_t expectedPresentTime = getExpectedPresentTime();

            expectedPresentTime = mScheduler->expectedPresentTime();

            if (layer->shouldPresentNow(expectedPresentTime)) {

            if (layer->shouldPresentNow(expectedPresentTime)) {

                mLayersWithQueuedFrames.push_back(layer);

                mLayersWithQueuedFrames.push_back(layer);

            } else {

            } else {

services/surfaceflinger/SurfaceFlinger.h

+5 −0
Original line number Original line Diff line number Diff line
@@ -298,6 +298,11 @@ public: 
    // TODO: this should be made accessible only to MessageQueue

    // TODO: this should be made accessible only to MessageQueue

    void onMessageReceived(int32_t what);

    void onMessageReceived(int32_t what);





    // Returns the expected present time for this frame.

    // When we are in negative offsets, we perform a correction so that the

    // predicted vsync for the *next* frame is used instead.

    nsecs_t getExpectedPresentTime();



    // for debugging only

    // for debugging only

    // TODO: this should be made accessible only to HWComposer

    // TODO: this should be made accessible only to HWComposer

    const Vector<sp<Layer>>& getLayerSortedByZForHwcDisplay(DisplayId displayId);

    const Vector<sp<Layer>>& getLayerSortedByZForHwcDisplay(DisplayId displayId);