Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 297bc933 authored by Chavi Weingarten's avatar Chavi Weingarten Committed by Android (Google) Code Review
Browse files

Merge "Handle null buffer when calling Transaction::setBuffer" into tm-dev

parents a91d8576 d1bda4b8

libs/gui/SurfaceComposerClient.cpp

+7 −0
Original line number Diff line number Diff line
@@ -1497,6 +1497,13 @@ SurfaceComposerClient::Transaction& SurfaceComposerClient::Transaction::setBuffe 


    releaseBufferIfOverwriting(*s);



    if (buffer == nullptr) {

        s->what &= ~layer_state_t::eBufferChanged;

        s->bufferData = nullptr;

        mContainsBuffer = false;

        return *this;

    }



    std::shared_ptr<BufferData> bufferData = std::make_shared<BufferData>();

    bufferData->buffer = buffer;

    uint64_t frameNumber = sc->resolveFrameNumber(optFrameNumber);

services/surfaceflinger/tests/ReleaseBufferCallback_test.cpp

+18 −0
Original line number Diff line number Diff line
@@ -465,4 +465,22 @@ TEST_F(ReleaseBufferCallbackTest, DISABLED_MergeBuffers_Different_Processes) { 
    ASSERT_NO_FATAL_FAILURE(waitForReleaseBufferCallback(*releaseCallback, firstBufferCallbackId));

}



TEST_F(ReleaseBufferCallbackTest, SetBuffer_OverwriteBuffersWithNull) {

    sp<SurfaceControl> layer = createBufferStateLayer();

    ReleaseBufferCallbackHelper* releaseCallback = getReleaseBufferCallbackHelper();



    sp<GraphicBuffer> firstBuffer = getBuffer();

    ReleaseCallbackId firstBufferCallbackId(firstBuffer->getId(), generateFrameNumber());



    // Create transaction with a buffer.

    Transaction transaction;

    transaction.setBuffer(layer, firstBuffer, std::nullopt, firstBufferCallbackId.framenumber,

                          releaseCallback->getCallback());



    // Call setBuffer on the same transaction with a null buffer.

    transaction.setBuffer(layer, nullptr, std::nullopt, 0, releaseCallback->getCallback());



    ASSERT_NO_FATAL_FAILURE(waitForReleaseBufferCallback(*releaseCallback, firstBufferCallbackId));

}



} // namespace android