Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28a83d42 authored by Pablo Ceballos's avatar Pablo Ceballos Committed by The Android Automerger
Browse files

BQ: Add permission check to BufferQueueConsumer::dump 

Bug 27046057

Change-Id: Id7bd8cf95045b497943ea39dde49e877aa6f5c4e
parent 6df23e81

libs/gui/BufferQueueConsumer.cpp

+15 −1
Original line number Diff line number Diff line
@@ -26,6 +26,10 @@ 
#include <gui/IConsumerListener.h>

#include <gui/IProducerListener.h>



#include <binder/IPCThreadState.h>

#include <binder/PermissionCache.h>

#include <private/android_filesystem_config.h>



namespace android {



BufferQueueConsumer::BufferQueueConsumer(const sp<BufferQueueCore>& core) :
@@ -572,7 +576,17 @@ sp<NativeHandle> BufferQueueConsumer::getSidebandStream() const { 
}



void BufferQueueConsumer::dump(String8& result, const char* prefix) const {

    const IPCThreadState* ipc = IPCThreadState::self();

    const pid_t pid = ipc->getCallingPid();

    const uid_t uid = ipc->getCallingUid();

    if ((uid != AID_SHELL)

            && !PermissionCache::checkPermission(String16(

            "android.permission.DUMP"), pid, uid)) {

        result.appendFormat("Permission Denial: can't dump BufferQueueConsumer "

                "from pid=%d, uid=%d\n", pid, uid);

    } else {

        mCore->dump(result, prefix);

    }

}



} // namespace android