Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23c30e9e authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder_ndk: clarify error prune functions 

libbinder_ndk has some functionality to prevent unknown errors from
propagating out of an NDK API, but these error messages didn't clearly
indicate that the number they were printing is the unknown error value,
not the value the error is changed to.

Bug: 166822339
Test: N/A
Change-Id: I54a8aa22413cb5b32f2a75e84ddaeb05fc378b9e
parent 0fd8d797

libs/binder/ndk/status.cpp

+4 −4
Original line number Diff line number Diff line
@@ -123,8 +123,8 @@ binder_status_t PruneStatusT(status_t status) { 
            return STATUS_UNKNOWN_ERROR;



        default:

            LOG(WARNING) << __func__

                         << ": Unknown status_t pruned into STATUS_UNKNOWN_ERROR: " << status;

            LOG(WARNING) << __func__ << ": Unknown status_t (" << status

                         << ") pruned into STATUS_UNKNOWN_ERROR";

            return STATUS_UNKNOWN_ERROR;

    }

}
@@ -155,8 +155,8 @@ binder_exception_t PruneException(int32_t exception) { 
            return EX_TRANSACTION_FAILED;



        default:

            LOG(WARNING) << __func__

                         << ": Unknown status_t pruned into EX_TRANSACTION_FAILED: " << exception;

            LOG(WARNING) << __func__ << ": Unknown binder exception (" << exception

                         << ") pruned into EX_TRANSACTION_FAILED";

            return EX_TRANSACTION_FAILED;

    }

}