Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 210bb7ea authored by Greg Kaiser's avatar Greg Kaiser
Browse files

Use const reference in setGpuStats() API 

Rather than make a copy of these strings when the function is
called, we pass them by const reference.

Test: TreeHugger
Change-Id: Ief53fea1f6df191181e00eab978cf53b5a2ab91d
parent 07698602

libs/graphicsenv/GraphicsEnv.cpp

+3 −3
Original line number Diff line number Diff line
@@ -156,9 +156,9 @@ void GraphicsEnv::setDriverPath(const std::string path) { 
    mDriverPath = path;

}



void GraphicsEnv::setGpuStats(const std::string driverPackageName,

                              const std::string driverVersionName, const uint64_t driverVersionCode,

                              const std::string appPackageName) {

void GraphicsEnv::setGpuStats(const std::string& driverPackageName,

                              const std::string& driverVersionName,

                              const uint64_t driverVersionCode, const std::string& appPackageName) {

    ATRACE_CALL();



    ALOGV("setGpuStats:\n"

libs/graphicsenv/IGpuService.cpp

+3 −3
Original line number Diff line number Diff line
@@ -27,9 +27,9 @@ class BpGpuService : public BpInterface<IGpuService> { 
public:

    explicit BpGpuService(const sp<IBinder>& impl) : BpInterface<IGpuService>(impl) {}



    virtual void setGpuStats(const std::string driverPackageName,

                             const std::string driverVersionName, const uint64_t driverVersionCode,

                             const std::string appPackageName) {

    virtual void setGpuStats(const std::string& driverPackageName,

                             const std::string& driverVersionName, const uint64_t driverVersionCode,

                             const std::string& appPackageName) {

        Parcel data, reply;

        data.writeInterfaceToken(IGpuService::getInterfaceDescriptor());

libs/graphicsenv/include/graphicsenv/GraphicsEnv.h

+2 −2
Original line number Diff line number Diff line
@@ -47,8 +47,8 @@ public: 
    //     /data/app/com.example.driver/base.apk!/lib/arm64-v8a

    void setDriverPath(const std::string path);

    android_namespace_t* getDriverNamespace();

    void setGpuStats(const std::string driverPackageName, const std::string driverVersionName,

                     const uint64_t versionCode, const std::string appPackageName);

    void setGpuStats(const std::string& driverPackageName, const std::string& driverVersionName,

                     const uint64_t versionCode, const std::string& appPackageName);

    void sendGpuStats();



    bool shouldUseAngle(std::string appName);

libs/graphicsenv/include/graphicsenv/IGpuService.h

+3 −3
Original line number Diff line number Diff line
@@ -32,9 +32,9 @@ public: 
    DECLARE_META_INTERFACE(GpuService);



    // set GPU stats from GraphicsEnvironment.

    virtual void setGpuStats(const std::string driverPackageName,

                             const std::string driverVersionName, const uint64_t driverVersionCode,

                             const std::string appPackageName) = 0;

    virtual void setGpuStats(const std::string& driverPackageName,

                             const std::string& driverVersionName, const uint64_t driverVersionCode,

                             const std::string& appPackageName) = 0;

};



class BnGpuService : public BnInterface<IGpuService> {

services/gpuservice/GpuService.cpp

+3 −3
Original line number Diff line number Diff line
@@ -37,9 +37,9 @@ const char* const GpuService::SERVICE_NAME = "gpu"; 


GpuService::GpuService() = default;



void GpuService::setGpuStats(const std::string driverPackageName,

                             const std::string driverVersionName, const uint64_t driverVersionCode,

                             const std::string appPackageName) {

void GpuService::setGpuStats(const std::string& driverPackageName,

                             const std::string& driverVersionName, const uint64_t driverVersionCode,

                             const std::string& appPackageName) {

    ATRACE_CALL();



    std::lock_guard<std::mutex> lock(mStateLock);