Merge "Fix FD comparisons in binder" (1a9db506) · Commits · e / os / android_frameworks_native-old

libs/binder/IPCThreadState.cpp

+5 −5

Original line number	Diff line number	Diff line
		@@ -421,7 +421,7 @@ void IPCThreadState::clearCaller()

		void IPCThreadState::flushCommands()
		{
		if (mProcess->mDriverFD <= 0)
		if (mProcess->mDriverFD < 0)
		return;
		talkWithDriver(false);
		// The flush could have caused post-write refcount decrements to have
		@@ -574,7 +574,7 @@ void IPCThreadState::joinThreadPool(bool isMain)

		int IPCThreadState::setupPolling(int* fd)
		{
		if (mProcess->mDriverFD <= 0) {
		if (mProcess->mDriverFD < 0) {
		return -EBADF;
		}

		@@ -878,7 +878,7 @@ finish:

		status_t IPCThreadState::talkWithDriver(bool doReceive)
		{
		if (mProcess->mDriverFD <= 0) {
		if (mProcess->mDriverFD < 0) {
		return -EBADF;
		}

		@@ -936,7 +936,7 @@ status_t IPCThreadState::talkWithDriver(bool doReceive)
		#else
		err = INVALID_OPERATION;
		#endif
		if (mProcess->mDriverFD <= 0) {
		if (mProcess->mDriverFD < 0) {
		err = -EBADF;
		}
		IF_LOG_COMMANDS() {
		@@ -1246,7 +1246,7 @@ void IPCThreadState::threadDestructor(void *st)
		if (self) {
		self->flushCommands();
		#if defined(__ANDROID__)
		if (self->mProcess->mDriverFD > 0) {
		if (self->mProcess->mDriverFD >= 0) {
		ioctl(self->mProcess->mDriverFD, BINDER_THREAD_EXIT, 0);
		}
		#endif