Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a971638 authored by Adithya Srinivasan's avatar Adithya Srinivasan
Browse files

Trace DisplayFrame present time as the slice end time 

To find the present time of a frame, we'd have to go to hw vsync
track and check for the fence signal time. To make things easier, this
change traces the DisplayFrame's present time as the slice's end time.
This also makes it inline with the expected track which uses present
time (end and present are same for sf predictions).

Bug: 180423820
Test: libsurfaceflinger_unittest
Change-Id: I2359417337eb08cde0adb881101087fa37d4e6f2
parent 891004e1

services/surfaceflinger/FrameTimeline/FrameTimeline.cpp

+1 −1
Original line number Diff line number Diff line
@@ -974,7 +974,7 @@ void FrameTimeline::DisplayFrame::traceActuals(pid_t surfaceFlingerPid) const { 
    FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) {

        auto packet = ctx.NewTracePacket();

        packet->set_timestamp_clock_id(perfetto::protos::pbzero::BUILTIN_CLOCK_MONOTONIC);

        packet->set_timestamp(static_cast<uint64_t>(mSurfaceFlingerActuals.endTime));

        packet->set_timestamp(static_cast<uint64_t>(mSurfaceFlingerActuals.presentTime));



        auto* event = packet->set_frame_timeline_event();

        auto* actualDisplayFrameEndEvent = event->set_frame_end();

services/surfaceflinger/tests/unittests/FrameTimelineTest.cpp

+2 −2
Original line number Diff line number Diff line
@@ -915,7 +915,7 @@ TEST_F(FrameTimelineTest, traceDisplayFrame_emitsValidTracePacket) { 
    // Packet - 3 : FrameEnd (ActualDisplayFrame)

    const auto& packet3 = packets[3];

    ASSERT_TRUE(packet3.has_timestamp());

    EXPECT_EQ(packet3.timestamp(), 26u);

    EXPECT_EQ(packet3.timestamp(), 31u);

    ASSERT_TRUE(packet3.has_frame_timeline_event());



    const auto& event3 = packet3.frame_timeline_event();
@@ -969,7 +969,7 @@ TEST_F(FrameTimelineTest, traceDisplayFrame_predictionExpiredDoesNotTraceExpecte 
    // Packet - 1 : FrameEnd (ActualDisplayFrame)

    const auto& packet1 = packets[1];

    ASSERT_TRUE(packet1.has_timestamp());

    EXPECT_EQ(packet1.timestamp(), 26u);

    EXPECT_EQ(packet1.timestamp(), 31u);

    ASSERT_TRUE(packet1.has_frame_timeline_event());



    const auto& event1 = packet1.frame_timeline_event();