Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 161495e2 authored by Kalesh Singh's avatar Kalesh Singh
Browse files

Don't retry getting memtrack hal service 

On devices where the AIDL memtrack hal is absent, this can cause many
service manager errors in logcat, since we retry getting the AIDL hal
for each getMemory() call.

servicemanager: Could not find android.hardware.memtrack.IMemtrack/defaut ...

The hal services get started before we start the proxy service, so it's
ok to remove this retry.

Bug: 177664629
Test: Manual
Change-Id: I2512e7eef0224d36827c0a4611373d0655cefc2f
parent 2c2c5d19

services/memtrackproxy/MemtrackProxy.cpp

+2 −4
Original line number Original line Diff line number Diff line
@@ -122,11 +122,9 @@ ndk::ScopedAStatus MemtrackProxy::getMemory(int pid, MemtrackType type, 




    _aidl_return->clear();

    _aidl_return->clear();





    if (memtrack_aidl_instance_ ||

    if (memtrack_aidl_instance_) {

        (memtrack_aidl_instance_ = MemtrackProxy::MemtrackAidlInstance())) {

        return memtrack_aidl_instance_->getMemory(pid, type, _aidl_return);

        return memtrack_aidl_instance_->getMemory(pid, type, _aidl_return);

    } else if (memtrack_hidl_instance_ ||

    } else if (memtrack_hidl_instance_) {

               (memtrack_hidl_instance_ = MemtrackProxy::MemtrackHidlInstance())) {

        ndk::ScopedAStatus aidl_status;

        ndk::ScopedAStatus aidl_status;





        Return<void> ret = memtrack_hidl_instance_->getMemory(

        Return<void> ret = memtrack_hidl_instance_->getMemory(