Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1383d9fc authored by Colin Cross's avatar Colin Cross
Browse files

Replace -Weverything with -Wextra 

-Weverything is not recommended, use -Wextra.

Requires adding a few more disabled warnings to libvulkan,
-Weverything appears to not turn on warnings that were disabled
by earlier command line arguments, while -Wextra does.

Bug: 143713277
Test: m native
Change-Id: I3997c2afe094deca66018e3cc43921aaecd82028
parent 9aebaa1f

libs/binder/tests/Android.bp

+1 −6
Original line number Diff line number Diff line
@@ -119,12 +119,7 @@ cc_test { 
    srcs: ["binderSafeInterfaceTest.cpp"],



    cppflags: [

        "-Weverything",

        "-Wno-c++98-compat",

        "-Wno-c++98-compat-pedantic",

        "-Wno-global-constructors",

        "-Wno-padded",

        "-Wno-weak-vtables",

        "-Wextra",

    ],



    cpp_std: "experimental",

libs/sensor/Android.bp

+1 −16
Original line number Diff line number Diff line
@@ -21,22 +21,7 @@ cc_library_shared { 
        "-Werror",

    ],

    cppflags: [

        "-Weverything",



        // The static constructors and destructors in this library have not been noted to

        // introduce significant overheads

        "-Wno-exit-time-destructors",

        "-Wno-global-constructors",



        // We only care about compiling as C++14

        "-Wno-c++98-compat-pedantic",



        // android/sensors.h uses nested anonymous unions and anonymous structs

        "-Wno-nested-anon-types",

        "-Wno-gnu-anonymous-struct",



        // Don't warn about struct padding

        "-Wno-padded",

        "-Wextra",

    ],



    srcs: [

libs/ui/Android.bp

+1 −22
Original line number Diff line number Diff line
@@ -26,28 +26,7 @@ cc_library_shared { 
        "-Werror",

    ],

    cppflags: [

        "-Weverything",



        // The static constructors and destructors in this library have not been noted to

        // introduce significant overheads

        "-Wno-exit-time-destructors",

        "-Wno-global-constructors",



        // We only care about compiling as C++14

        "-Wno-c++98-compat-pedantic",



        // We are aware of the risks inherent in comparing floats for equality

        "-Wno-float-equal",



        // We use four-character constants for the GraphicBuffer header, and don't care

        // that they're non-portable as long as they're consistent within one execution

        "-Wno-four-char-constants",



        // Don't warn about struct padding

        "-Wno-padded",



        "-Wno-switch-enum",

        "-Wno-format-pedantic",

        "-Wextra",

    ],



    sanitize: {

vulkan/libvulkan/Android.bp

+4 −3
Original line number Diff line number Diff line
@@ -41,12 +41,13 @@ cc_library_shared { 
        "-DVK_NO_PROTOTYPES",

        "-fvisibility=hidden",

        "-fstrict-aliasing",

        "-Weverything",

        "-Wextra",

        "-Werror",

        "-Wno-padded",

        "-Wno-sign-compare",

        "-Wno-switch-enum",

        "-Wno-undef",

        "-Wno-format-pedantic",

        "-Wno-unused-variable",

        "-Wno-unused-function",



        // Have clang emit complete debug_info.

        "-fstandalone-debug",